Behavior wrong or disappearance of slurs with linked staves
The situation was as follows at July 3. Proper operation.
Now, from the last few days, and the Nightly, July 14 (b408591) / Windows 7
Some cases with different behavior:
in Note entry mode, or in Out Note entry mode, specially but not only.
- Note entry mode, with linked staves (standard staff + tab staff)
Result: as a recent report bug, the slur is deleted by the entry of the second note. Despite the fact that this bug is now fixed since yesterday in single standard staff ... Congratulations for this.
Very good running now :-)
-Note entry mode, with tab staff added and linked to a standard staff afterwards (idem in the reverse case)
Result : the slurs of the tab staff are up, masked and merged with those of the standard staff.
It can be seen by separating the two staves. If you release, they return to the same location. If you separate them manually, one after another, and you save the partition as such, you will have a crash when reopening the document.
In all ways, the slurs of the tab staff probably (or standard?) disappear when you save and reopen the score.
- The file mscz slur mscz.mscz
- In Out note entry mode : (adding slurs afterwards)
It works well in the case with linked staves (standard and Tab) immediately at the creation of the document.
It does not work again in the case of Tab staff added and linked to a standard staff.
With the same result: the slurs of the Tab staff are hidden and merged, and disappear after saving and reopening the score.
| Attachment | Size |
|---|---|
| 1Slur.jpg | 58.21 KB |
| 2Slur.jpg | 18.31 KB |
| 3Slur.jpg | 28.59 KB |
| slur mscz.mscz | 2.29 KB |
Comments
Confirmed. Steps to reproduce:
1) create score for guitar, standard staff
2) add some notes
3) add a slur
4) add a linked staff (can be standard or tab)
Result: at first, you don't see the slurs for the linked staff at all - they are actually overlapping the slurs for the original staff. But drag the linked staff down and you see them, as shown in the picture above.
Thanks for reminding steps. You do it to one aspect (the second) of the issue.
I can do the same for the first aspect (I thought everything was clearly commented)
1) New score for guitar, standard staff + linked tab staff
2) Add some notes and slurs in note entry mode
Result: the slurs are deleted by the entry of the second note (as the second attachment).
Note that this issue occurs with linked staves (standard + tab, but also standard + standard). However, as we mentioned earlier, this issue was fixed in the case of a single standard staff: http://musescore.org/fr/node/27321,
and: https://github.com/musescore/MuseScore/commit/7108d9f070e1784739cb215aa…
You are correct. I misunderstood your first aspect and thought you were saying it was fixed now.
The second part of this is fixed by http://git.io/7BQ3kA
This first part is still active. To be clear, by "Add some notes and slurs in note entry mode", this means enter note entry mode, type a letter type S, then type another note". I clarify this because there are other ways of entering notes and slurs and they do work. For instance, the following works:
N C D Left S
The following does not:
N C S D
In other words, it is only the "pending slur mode" that does not work in the presence of linked staves. Adding slurs to existing notes works fine.
Indeed, the second part works now. Great. Thanks to Werner :)
For the first part (with linked staves immediatly, and in Note Entry Mode, always), the example you notice (C/D/Left arrow/S) works, it is true.
But it is not intuitive at all (I had never thought of this procedure!) Because you must realize a backtrack and use an extra key, the left arrow, for a total of four operations (thus, longer to implement)
The issue that I had submitted was like your second example, namely: Note/ S key /Second note, for a total of three operations.
And with the advantage to advance into the "logical" way of writing (from left to right, without backtracking), more fluid and pleasant, like the procedure in single standard staff.
Thus, the deletion of the slur by the entry of the second note continue to be an issue.
What do you think about that? Thanks.
Oh, definitely, the way you liek to enter slurs is easier and *should* be made to work. I made the steps more explicit this only because it might not have been clear from your description what it was you were doing that doesn't work. Your description simple said "add notes and slurs", but different people might try to do that different ways, and if they didn't do it the same way as you, they wouldn't be able to reproduce the bug.
FYI, the feature in question - being able to press "S" to start a slur while in Note Entry mode and then add notes - is a rather obscure one. You are probably one of the few people to know about it and use it :-). I think most people don't think about adding slurs while in note entry mode at all. They probably enter notes in note entry mode, then add slurs later after entering all notes, much as once often does for articulations, dynamics, voltas, etc.
I also think it's an easy process (I had noticed in Sibelius)
But I do not think to be "one of the few people to know about it and use it"! :-)
Indeed, this type of technical slurs (called Hammer "H", and Pull-Off "P.O": http://en.wikibooks.org/wiki/Guitar/Hammer-ons,_Pull-offs,_and_Trills) is very common in writing guitar, but also for bowed instruments, you know it, to signify that two, three, or four notes are played in the same bow stroke without stopping.
I tested several times. I think the process of adding slurs outside the note entry mode is longer.
So either we stay there, and the procedure works only in the case of a standard staff. And I will proceed otherwise when the staves will linked.
Or we try to have a consistent behavior when the staves are linked or not.
I do not know what to say more for the moment.
FWIW, the reason I think not many people know about this feature is that it wasn't documented until pretty recently. It wasn't in the Handbook for 1.0, 1.1, or 1.2; it was added to the online version sometime between the releases of 1.2 and 1.3. For all I know it has worked from the very beginning, but it still seems "new" to me :-).
FWIW, it's also very common for wind instrument, where it indicates notes that are not tongued. And in piano music, where it's just sort of a general "play this as one phrase, whatever that means to you" marking.
Fixed in 43b8b02e84
Oops, there is a crash now. Steps to reproduce:
1) Enter a note
2) Press S key (to start the process of slur entry)
3) Enter a second note
4) Press S key (to stop the process, but it can be done after several notes, whatever)
5) Enter a new note -> the crash occurs exactly at this time.
- You will also notice (second attachment) that in the Tab staff, only the slur between the first two notes work. This does not go beyond.
I just noticed that the same crash is happening now in the same way, but with a single Standard staff (that worked well after a recent correction)
In the case of Sibelius, the behavior is slightly different. By default, press S key generates a slur between just two notes (the most common case perhaps?)
Thus, it is not necessary to press again on the S key to stop the process. I do not know if this simplifies the implementation?
And if you want to extend a slur on three notes or more (always in Sibelius), only in this case, you must press the S key again as many times as necessary. Hard to say which is better.
Two note slurs might be most common in guitar music, but they'd be relatively less common than longer slurs in string, wind, and piano writing. So I think it would best if S continued to work as it does (or is supposed to).
BTW, the crash looks easy to fix, but not sure abotu the issue where the slurs don't extend properly on the tab staff. I also note the same problem occurs the other way around: if you enter your notes onto the tab staff, the slur extends correctly there, but not on the standard staff. The the slurs extents correctly on whicever staff you enter the notes onto, but stops after two notes on the other staff.
And the same thing happens for two normal staves, including score and part. So if you create a slur in this manner in the score (after generation of parts), the slur will always only be two notes long in the part.
You're right, surely. I first was wondering if there was a simpler and more stable way (or not) to implement this feature?
EDIT: It's a boring question that you raise about slurs which would not extended to linked staves or with normal staves including score and part.
If this is not possible, never mind, go back to the behavior of yesterday, with the proper running with single standard staff. Because, in a second time, it is always possible to add and link a Tab staff, and in this case, it works.
More simpler maybe? It will just that the user knows that.
I assume that yesterdays build would also not have worked correctly with linked parts, and it *is* important to get those to work. The user would be unlikely to notice until too late that the slurs were not added correctly in the parts.
Anyhow, I have no doubt this all can and will be fixed. It's just tricky, apparently :-). The good news is, it's really one of just a small handful of "showstopper" bugs left, so I am confident it will get the attention it needs. If Werner gets tired of dealing with this, I'm happy to take a look too.
Ok Marc (and Werner), made for the better. I do not make it personal.
All I can say is that I appreciate this feature of adding slurs in the Note entry mode (it's a good alternative and complementary way to do it), as I could do it in a standard staff these last days.
If I was a programmer, I would help my best. Alas, alas hundred times, it is totally beyond my skills. I am a musician, only! (:
Fixed in 8d3d3f2da4
slur behaved wrong in the linked tab staff but i cannot reproduce any crash
Werner: the crash was here:
https://github.com/musescore/MuseScore/blob/8d3d3f2da401d4670e820d2a3eb…
Until yesterday, there was no "if (slur)" around that section of code, so there was a crash dereferencing a null "slur". This happened after you completed slur entry (by pressing S again) and then tried to enter another note (eg, C S D S E).
From my perspective, this does in fact now all work as expected now, including score/parts. Slurs extend correctly, no crashes!
Yes, thanks :-) There is no more crash.
We are really close to the perfect result. However, I noticed another problem to copy and paste or repeated. The attached file explains everything. Copy-past.mscz
I think we should reopen (because it is annoying in current use) the issue - one last time, hopefully for you -, but with normal status. I leave it to Marc the care to do, if he thinks necessary.
I also think I spotted a small issue with the extraction part. The slurs are present, but it seems to have a problem with a change of clefs : Treble clef -> treble 8vb seems active for only a few measures, and not for the whole score. I try to reproduce and I confirm or not.
I can confirm the bug with copy and paste, but since it is really a separate thing from note entry, how about we give this particular issue a rest :-). I'll submit the new bug separately.
I agree. Yes please, submit separately the new bug (that is very well known for having been treated there a few days) :-)
So, I hope we are confident for the fix :)
Automatically closed -- issue fixed for 2 weeks with no activity.