[branch 1.2] Articulations / ornaments in small staves are not small

• Jan 13, 2012 - 23:51
Type
Functional
Severity
S4 - Minor
Status
closed
Project

Setup: SVN rev. 5215; compiled with latest Qt SDK (Qt Creator 2.4, Qt lib 4.7.4) under Windows XP SP3.

Steps:
1) open or create any score
2) set one the score staves as small, if none already is (a simple test score is attached)
3) add an articulation / ornament to a note of the small stave

Result:
The articulation or ornament is not drawn small, but at full size.

In the sample score attached, the trill symbol in the top stave (small) has the same size of the trill in the bottom, normal-sized, stave.

The Patch:

This happens because nowhere the _mag member of the articulation symbol is set to the _mag value of the stave.

The attached patch corrects this by adding a few lines to the ChordRest::layoutArticulations() function (file chordrest.cpp, lines 356 and foll.) to copy the magnification of the staff the chord/rest belongs to into its articulations.

This function seemed the most reasonable place where to add such code.

Thanks,

M.


Comments