Former key signature isn't restored after Undo Transpose
1. Open attached score.
2. 'Select All'.
3. 'Transpose...'.
4. Select different key signature.
5. 'OK'.
6. 'Undo'.
Result: The former key signature isn't restored - notes appear with accidentals, instead.
Using MuseScore 2.0 Nightly Build (5637) - Mac 10.7.4.
| Attachment | Size |
|---|---|
| Former key signature isn't restored after Undo Transpose.mscz | 1.58 KB |
Comments
The behaviour is now different - maybe it's a different report.
The former key signature is restored, but all notes at the beginning of every bar are naturals.
Using MuseScore 2.0 Nightly Build (6ccb7e3) - Mac 10.7.4.
The naturals seem due to the fact, that the new(transposed) keysig still stays, it's just not shown.
Try this: After undo just select any note and change it (eg. UP-key) and the keysig comes back.
Using cc19041 on Ubuntu 12.04
See https://github.com/musescore/MuseScore/pull/65 for a fix.
Nice one heuchi :).
Pull request got withdrawn and closed. What about a fix for this problem then?
https://github.com/musescore/MuseScore/pull/264
http://musescore.org/en/node/20394#comment-76235 marked as duplicate of this.
Marked as critical, since a score with several key signature changes and transposing instruments can result in significant data loss.
http://musescore.org/en/node/20393#comment-76096 should also be checked after this issue is fixed
I wonder whether this issue should be closed because the keysig comes now back after undoing a transposition, but the score is messed up with accidentals which might be another issue. (checked with 63fe67a)
This one?: #21234: Naturals appear for notes that would have been an accidental of previous key signature after undo transpose
I just tested using e4173e8 and I don't see any change since comments #1 and #2.
Maybe the confusion comes from the fact, that the original steps don't show the real problem any more, because a last step, which I mention in comment #2 (do any edit, and the old (transposed) keysig returns) is missing. #21234: Naturals appear for notes that would have been an accidental of previous key signature after undo transpose doesn't clarify that either.
IMHO if we want to improve on this we should close both issues and set up a complete new one which includes the step of comment #2 to show that the keysig actually still is not restored by undo.
BTW, half a year ago I suggested a simple fix for this. I did however not receive any comment on it.
#21234 is still reproducible, so I don't see why it should be closed.
This, on the other hand, doesn't seem to be reproducible.
This issue seem to be stuck since quite while, is the pull request not good enough?
Or doesn't apply any more?
The specific of this issue (key signature not restored on undo) has been solved.
The point about superfluous accidentals appearing after undo is till true, but it is covered by the other issue quoted: #21234: Naturals appear for notes that would have been an accidental of previous key signature after undo transpose.
FWIW, my opinion is that this issue should be marked as fixed and closed.
M.
So let's close this issue and get someone (?) to close the PR...
The story continues in #23525: Updated 16506: Former key signature isn't restored after Undo Transpose
Automatically closed -- issue fixed for 2 weeks with no activity.