Remove "Enable sound while editing" button from toolbar

• Sep 12, 2013 - 17:43
Type
Graphical (UI)
Severity
S4 - Minor
Status
closed
Project

The toolbar button "Enable sound while editing" seems redundant.? We already have a preference setting in Edit > Preferences > Note Entry.

Also the two settings are not linked, so if one is checked and the other isn't there is no sound.

I suggest removing the toolbar icon, since it is not a feature that most users will frequently change.


Comments

Status (old) fixed needs info

Not sure it is related, but this fix apparently removed not only the button from the toolbar but also its shortcut ("sound-on") from the shortcut list in the code.

As a consequence, an existing shortcut.xml config file causes an error (small annoyance) and the program crashes at startup (which is worse!).

I'm setting this issue back to "needs info"; if the shortcut removal is intentional please set it back to "fixed".

In this case, it might be useful to other testers to know that the shortcut.xml file can be manually edited to remove the "sound-on" shortcut (before resorting to resetting to factory defaults, which is rather destructive on most customizations one may have added).

Thanks,

M.

Status (old) needs info fixed

Indeed I removed the shortcut, but MuseScore should not crash if a alien shortcut is defined in shortcuts.xml. I tried to fix this behavior in 50039614b5