PlayPanel dB value not updated when master volume changed in mixer

• Jun 28, 2019 - 12:38
Reported version
3.2
Type
Ergonomical (UX)
Frequency
Once
Severity
S4 - Minor
Reproducibility
Always
Status
closed
Regression
No
Workaround
No
Project
MuseScore

Open Mixer. Open Play Panel. Move the Master Gain control on the Mixer. The Master volume slider in the Play Panel moves in sync. But the decibels value in the box below does not.

This is because when gainChanged() SIGNAL sent by the MasterSynthesizer to the PlayPanel's setGain() slot doesn't update the spin box. Fix is to amend PlayPanel::setGain(float) as follows:

void PlayPanel::setGain(float val)  // respond to gainChanged() SIGNAL from MasterSynthesizer
      {
      const QSignalBlocker blockVolumeSpinBoxSignals(volSpinBox);
      volumeSlider->setValue(val);
      vol = val;
      volLabel();
      }

However, looking into this reveals some further issues. The Mixer's Master Gain is in a range -3dB to 0dB. The Play Panel's Master volume is in the range -80dB to 0dB. That doesn't seem right? Can someone who know more about dB than I do say what it should be.

Comments

• Nov 22, 2019 - 13:04
Status active ⇒ fixed

Fixed in branch master, commit 8bac1fddde

_Fix #291901 & Fix #291453 Double-click resets Master Volume

  • put all the decibel conversion work into MasterSynthesizer
  • make a default gain value available from MasterSynthesizer
  • add double click for default value support to StyledSlider
  • amend PlayPanel, Mixer and SynthControl to interact with MasterSynthesizer only using decibels and making use of the provided default gain for double click
  • Fix #291453 is addressed as the Mixer now uses the default decibel range_

Reply

• Nov 22, 2019 - 13:04

Fixed in branch master, commit 8bac1fddde

_Fix #291901 & Fix #291453 Double-click resets Master Volume

  • put all the decibel conversion work into MasterSynthesizer
  • make a default gain value available from MasterSynthesizer
  • add double click for default value support to StyledSlider
  • amend PlayPanel, Mixer and SynthControl to interact with MasterSynthesizer only using decibels and making use of the provided default gain for double click
  • Fix #291453 is addressed as the Mixer now uses the default decibel range_

Reply

Fix version
3.3.3