Improve Tin Whistle instrument name by adding key
(note - my focus is on the "Tin Whistle" instrument that does not make its key explicit, at the top of the output but I list D and Bb for comparison purposes)
Current entries for the Tin Whistle
1) in the MusicXML instrument definition MusicXML sounds file
<sound id="wind.flutes.whistle.tin.bflat />
2) Which filters down to our instruments.xml
egrep -i "whistle|tin wh" instruments.xml | egrep -v -i "program|slide"
<longName>B♭ Tin Whistle</longName>
<shortName>B♭ Tin Wh.</shortName>
<longName>D Tin Whistle</longName>
<shortName>D Tin Wh.</shortName>
In my opinion, the name for the C instrument
is misleading. It omits the “.c”. My guess was ("was", see aside at the bottom for comparison with "C trumpet") it assumes C is the default or natural key for this instrument since Concert C is the default for most classical western pitched instruments. The C is not the most common tin whistle, D is:
and there is no context within which omitting the "C" would be acceptable from a scoring perspective, since there is no standard / default key, "D" being the closest.
My suggestion, change the above
longName: Tin Whistle -> C Tin Whistle
shortName: Tin Wh. -> C Tin Wh.
And if changing the Instrument ID will not interfere with other parts,
(for obvious reasons, the musicXMLid should remain as is)
Aside - for comparison, I looked at trumpet on the MusicXML instrument definition
And both bflat (the “default/standard” pitch) and c (the concert pitch instrument, equivalent to our C Tin Whistle without the C) are explicitly stated. Not having the ".c" in the sound ID makes even less sense since Tin whistle does not have a default/standard pitch.