Fretboard diagrams edit dialogue on double click.
There have been a variety of viewpoints regarding the issue whether double clicking on a fretboard diagram should allow editing the diagram , as in the case of chord symbols , or conventionally just take you to the "Edit Mode".
I am of the belief that it will be more convenient and intutive to allow editing the fretboard diagram on a double click as opposed to the edit dialog currently present only in the properties menu, accessible only after a left click.
The new implementation can result in the following design :
Double-Click on fretboard : editor dialog appears
Single-Click on fretboard : Enters the Edit mode and allows fine adjustment using arrow keys.
This is the same design as currently used for chord symbols , wherein , double click allows for editing the chord and single click takes you to "edit mode".
In addition to being more intutive and *usually expected* , one argument in support of the above change can be that a fretboard diagram is indeed a graphical representation of a chord symbol , so , its quite reasonable for it to behave similar to a chord symbol.
Hence , I would like to propose the above mentioned design change in fretboard diagrams , if suited .
Comments
Actually, for text-based elements like chord symbols, double-click still enters edit mode, just like selecting it and pressing [Cmd]+[E] or right-clicking and choosing "Edit Element." It's just that text edit mode does allow you to edit the text. Single-clicking a text element does not enter edit mode.
In reply to Actually, for text-based by Isaac Weiss
Single-Click on a text element does take you to the "edit mode" , wherein , you can finetune the placement using arrow keys.
Note , here I am not referring to the text-edit mode .
In reply to Single-Click on a text by abhinav_
Actually, what single-click does with text seems to be sort of a "special" mode, neither normal "edit" mode nor "text edit" mode. It's technically still "normal" mode, but the handling of arrow keys with text selected is special-cased in the code (in ScoreView::cmd(), the handling of "next-chord" and other commands).
Anyhow, I am inclined to agree that double click would more naturally be expected to display the editor, and a single click could then enable keyboard nudging as with text, via the same special casing in ScoreView::cmd(). Although that solution is a bit of a hack; I wouldn't mind seeing something more elegant. But if it ain't broke...
In reply to Actually, what single-click by Marc Sabatella
I do think it would be a nice thing for double-clicking a fretboard diagram to open its Properties. But if you want to verify that edit mode for text really is "text edit mode", right-click a piece of text and choose "Edit Element."
I might point out that resizable items (mostly lines) also have a unique sort of edit mode. But it's true that you can't move those any direction with the arrow keys.
In reply to I do think it would be a nice by Isaac Weiss
In that case ,shouldn't the "Edit Element" option available on right click on a chord symbol also take you the the special editing mode as opposed to "text-edit" mode for consistency sake?
Seldom would users want to make the effort to right click and then click on an option to be able to "text-edit".
In reply to In that case ,shouldn't the by abhinav_
I'm not sure what you mean. I'm saying that right-click-"Edit Element", single-click-[Cmd]+[E], and double-click are always consistent with each other, including for text, including for chord symbols.
In reply to I'm not sure what you mean. by Isaac Weiss
@ZackTheCardshark : I was taking of consistency of all the text elements with other elements , in which edit option in menu takes you to a mode that allows positioning of the element with arrows. Similar behaviour of the edit option in the menu for text elements would be good I think.
In reply to In that case ,shouldn't the by abhinav_
I don't understand what you are asking. "Edit element" for text elements takes you to text edit mode. I am not sure what else you'd expect it to do.
In reply to I don't understand what you by Marc Sabatella
I was saying , just as "edit element" in fretboard diagram takes you to editing mode allowing positioning with arrows, shouldnt the same behaviour be there for "edit element" of chord symbols?
In reply to I was saying , just as "edit by abhinav_
Chord symbols are text. So "edit element" does the same thing with chord symbols as it does for all other text. As I mentioned, there is no separate mode for positioning text (including chord symbols) - it is done directly from normal mode, no mode change required.
In reply to Chord symbols are text. So by Marc Sabatella
Oh, in that case its fine.
I thought the single click in case of text actually takes you to another special mode which in addition to positioning with arrows offers some other functionality too.
If its not so , then the present options for text would be fine.
Coming back, more views on whether to implement double click as a feature for fretboard-diagram-editing ?
What about keeping double click alone, but move fretboard properties in the inspector?
In reply to What about keeping double by [DELETED] 5
keeping double click for ?
In reply to keeping double click for ? by abhinav_
Keeping double click for what it's used right now for all non textual element: entering edit mode (which is probably not well named), meaning the mode in which you can move the element with the arrow keys.
In reply to Keeping double click for what by [DELETED] 5
I like it in a Properties dialog, but I think double-click to access that dialog for this case is a decent idea, with single-click allowing movement being ideal.