Checking with PVS-Studio static analyser
To demonstrate the capabilities of our analyzer, we regularly perform analysis of open source projects. We had recently checked the MuseScore project.
Here is the link to the article about it: Review of Music Software Code Defects Part 1. MuseScore
If you have any questions, or if you are interested in the evaluation of our static analyzer or in any other source code quality control services that our company provides, please contact us at support@viva64.com.
Comments
Thanks for that and we're actually already actively looking into that, since some 2 hours ;-)
In reply to Thanks for that and we're… by Jojo-Schmitz
https://www.viva64.com/en/b/0530/#ID0E2DGK
code pluginCreator.cpp, lines 81-88
those 2 statements in the else branch need to get swapped.
And your analysis missed a 2nd such flaw, in musescore.cpp, lines 752-759
In both cases we deal with menus in left-to-right vs. right-to-left languages
Not at all sure about the intention of the upLine() vs. downLine() in rest.cpp, lines 657-671
The 2 lines at importgtp-gp6.cpp, lines 100-101 are plain wrong indeed. The duplication is not needed and the remaining line needs to read
{"oboe", "oboe"},and should get moved down a few lines to keep the alphabetical order.The assignment in rendermidi.cpp, line 1176 may be superfluous, but certainly is harmless and most probably stems from a copy of line 1154
I don't understand the issue with pulseaudio.cpp, line 206, mind to elaborate?
A first go at the issues described here can now be found in https://github.com/musescore/MuseScore/pull/3302
In reply to A first go at the issues… by Jojo-Schmitz
This got merged