French translation of QT strings are lost in 2.2 since PR 3272

• Dec 12, 2017 - 19:19

As MuseScore 2.2 is build with QT 5.4 , and this release of QT does not provide French translations of QT strings, the words as "OK, Apply, Cancel, etc." are now untranslated.

As a test of a workaround, I have copied the missing files from the translations directory of QT 5.8 used for build MuseScore 3.0, in my setup, the destination directory is : C:\Qt\5.4\mingw491_32\translations
Files copied are :
- qt_fr.qm
- qtbase_fr.qm
- qtmultimedia_fr.qm
- qtquick1_fr.qm
- qtscript_fr.qm
- qtxmlpatterns_fr.qm
Note that the new qt_fr.qm is only 1 KB and replace the one present in the directory which is 250 KB

After compiling the last 1ea547c release of 2.2, all QT strings are translated in French.
May be more testing of all Dialogs box should be taken.

It would be nice if those files will be installed on the buid server, so all 2.2 nightlies and the future release of 2.2 will be correctely translated in French.

Thanks in advance
JL

Comments

• Dec 13, 2017 - 01:23

This is by design, to fix #243516: Untranslated strings, from Qt, we rely on the translations provided by Qt now. I don't think it is a good idea to take the translations from one version and copy them to another, they really should match the lib version that gets used even if that has some collateral damage for some strings in some languages

Reply

• Dec 13, 2017 - 05:28

Thanks for reply, but it was "by design" to have ALL strings translated before PR 3272, for which French translators have worked for years (I was one of them).
I undestand the utility of this PR for 3.0 which rely of QT 5.8 but not for 2.2 which use QT 5.4
Minor behavior I guess, but 2.2 looks unfinished while this is the more stable release, even the use of latest nightly.
I have verified that incorporating the QT 5.8 files does not conflict during compilation, but it is easy to manually copy them in the locale folder when a nightly build is published.
May be a solution to be proposed to French people on their translation forum.

Reply

• Dec 13, 2017 - 08:54

I don't quite understand, the qt_XX.ts files that used to be part of MuseScore have never been continuously worked on (unline the mscoce:__ts files), thay had at some time been copied from a very early Qt version (4.8 or even older) and never got updated to those from a later version, and only very rarely got changed manually, and never ever by you (well, not since the source code moved away from SourceForge to GitHub back in 2012, so never for the 2.x releases):

$ git log -- share/locale/qt_fr.ts
commit 41b7906b2b68c164a5d241b9f7cde7881dff7dcd
Author: Joachim Schmitz <--censored-->
Date: Fri Aug 11 09:23:32 2017 +0200

Fix #243516: Untranslated strings, from Qt

Remove all Qt translations from the MuseScore repository
that are also part of Qt 5.4 and later, and deploy Qt's instead.
Also , as a side effect, deploy our Bulgarian translation for Qt
(seems a day one ommision and not needed for Qt-5.9.1 and later)

Simplify the whole process for adding languages and running lupdate

Should be good for master and 2.2

commit 8fb3961838b7b60b312a4aeb53e70087a8a26461
Author: lasconic <--censored-->
Date: Sat Mar 14 07:37:02 2015 +0100

fix #50531: [Mac OSX] 'Don't save' is not translated

commit 504b954a25cd0a25ad4830ed9ce6a85ff4be7eb7
Author: Joachim Schmitz
Date: Wed Sep 3 13:35:48 2014 +0200

fix #30266: Some button labels are not translated

Fixed by replacing QDialogBottonBox by QPlatformTheme, which seems what
Qt 5.2 (?) and 5.3 (!) needs as the context, to load the right
translations for these button labels.

Also some more cosmetic fixes for the German translation

commit 412ca45401009faba19c1c1ab505153f9f436e7f
Author: Werner Schweer <--censored-->
Date: Sat May 26 14:49:10 2012 +0200

Initial commit

Yes, it wont' conflict on compilation, but the real questions are
a) will all the strings from Qt 5.8 or later work fine when used with libraries from Qt 5.4? I don't think this to be very likely.
b) how to do this in the controlled build environment that is used to create the nightly 2.2 builds, without introducing some maintenance nightmare?

Reply

• Dec 13, 2017 - 10:16

Understood, but the lonly things I tell is before this modification all strings was translated in French.
Verified in :
- MS 2.1 release 871c8ce
- MS 2.2 nightly c86c9c6
After this nightly, all QT string had been reverted in en-US as QT 5.4 does not have French translations

If install more recent files on the build server is a dificulty, they could be hosted in the Git repository of the 2.2 branch, with the necessary copy process.

Copy files on our local system is really simple, for you, for me, but I am sure that could be difficult for all MuseScore users, it's why my attempt to create a feature request to restore the translated missing strings.

I know this is minor, but contribute to have a beautiful MuseScore 2.2

Reply

• Dec 13, 2017 - 10:22

Surely not all strings have been reverted to en_US, only those where Qt does not provide a French translation in 5.4.
As long as we're not really sure that the strings of a newer Qt work fine overall (and also in languages other then French) together with the older lib versions, I believe just taking those newer strings is asking for trouble.

Reply

• Dec 13, 2017 - 11:09

Yes sure, I speak only for the QT Strings such "OK, Apply, Cancel", all other contained in mscore_fr.ts are in French.
I have not verified the impact on other laguages other than en-US and fr-FR. but since I have copied the QT 5.8 files on my PC all strings are itranslated whithout any issue for the moment, 2 days of use.

I am using MuseScore in a daily basis, as I transcribe scores for my vocal and instrumental group, the musicians and chorists of the group really appreciate the scores made with MuseScore.

May be more testing should take place, but incorporating files in a Nightly for testing purpose by the community would be great.

Reply

• Dec 13, 2017 - 17:54

Thank you for the feedback and the extensive investigation. I will revert this change.
It's more important to me to have good and complete translation in one of the top language for MuseScore (and, yes, sure, it's also my native language ;) than having a clean code which look the same in master and 2.2. As far as I know we had 0 complain about the way the Qt translation handling work in 2.1. If we did, we can still fix it differently.

Reply

Do you still have an unanswered question? Please log in first to post your question.