Color note only for alterations

• Jun 16, 2019 - 14:53

Hi!
i tried to create a plugin. I used color note as source. I want to color note only if it's a sharp or a flat. I modified color note's plugin but it is always the original plugin which applies. I always have notes and color note in the menu.
I join the file to this post if someone knows what's wrong.
Thanks
Virginie

Attachment	Size
color notes alterees.qml	5.18 KB

Comments

virginief29

• Jun 16, 2019 - 14:58

Just one point : the note must be colored if it's altered. If the C is sharp I want the note C to be orange not the sharp.
Sorry for my english, I hope it's understandable.

Shoichi

• Jun 16, 2019 - 15:03

Select->more...

change colour via Inspector. Just a workaround, waiting for better answers.

virginief29

• Jun 16, 2019 - 16:03

Thank you very much. I didn't no this method to select notes. It's incredibly fast to color notes now.
It's very useful
However if someone can help me for the plugin, I would like to know what's wrong.

Jojo-Schmitz

• Jun 16, 2019 - 18:44

You have menuPath: "Plugins.Notes.Color Notes", that conflicts with the 'regular' color notes plugin, so change that to menuPath: "Plugins.Notes.Color Notes Alterations"
In

      function colorNote(note) {
            if (note.color == black)
                  note.color = colors[note.pitch % 12];
            else
                  note.color = black;
 
            if (note.accidental) {
                  if (note.accidental.color == black)
                        note.accidental.color = colors[note.pitch % 12];
                  else
                        note.accidental.color = black;
                  }
 
            for (var i = 0; i < note.dots.length; i++) {
                  if (note.dots[i]) {
                        if (note.dots[i].color == black)
                              note.dots[i].color = colors[note.pitch % 12];
                        else
                              note.dots[i].color = black;
                        }
                  }
         }

You're coloring note(head)s, accidentaly and augmentation dots, exactly like the color notes plugin does.
Instead try this:

      function colorNote(note) {
            if (note.accidental) {
                  if (note.color == black)
                        note.color = colors[note.pitch % 12];
                  else
                        note.color = black;
                  }
            for (var i = 0; i < note.dots.length; i++) {
                  if (note.accidental && note.dots[i]) {
                        if (note.dots[i].color == black)
                              note.dots[i].color = colors[note.pitch % 12];
                        else
                              note.dots[i].color = black;
                        }
                  }
         }

to color note(head)s and augmention dot, if the note has an accidental