Set "Save Required" flag

• Sep 26, 2020 - 17:13

I have a plugin to set note colour but the score doesn't get the asterisk symbol to show that the file has changed and it doesn't ask to save on closing. What do I need to set to flag the score as changed?

Comments

Jojo-Schmitz

• Sep 26, 2020 - 17:40

The color notes and color voices plugins do set that flag, it seems.

mike320

• Sep 26, 2020 - 18:10

Does this happen in the Qt.quit() call?

Jojo-Schmitz

• Sep 26, 2020 - 18:19

No idea

jeetee

• Sep 26, 2020 - 20:52

Don't call "Qt.quit()" as it shuts down the entire plugin engine and all active plugins: see https://musescore.org/en/node/304874#comment-999964 for some background info and context on that.

yonah_ag

• Sep 26, 2020 - 18:34

Thanks, I'll check it out and see what I've missed.

yonah_ag

• Sep 26, 2020 - 20:24

Couldn't find anything in "Colour Notes" so I'll check some other plugins. I'm using a docked dialogue and from reading other threads in this forum it looks like Qt.Quit() is a bad idea for them and doesn't look like it relates to the 'save required' flag.

yonah_ag

• Sep 26, 2020 - 20:41

Fixed

Needed to use startCmd() and endCmd()

function setFingerColour(fing)
{
    var note = find_note();
    if (!note) return false;
    curScore.startCmd();
    note.color = fingrgb[fing];
    curScore.endCmd();
}

Jojo-Schmitz

• Sep 26, 2020 - 20:44

That's what I thought, before I looked at those plugins mentioned above, They don't do this

yonah_ag

• Sep 26, 2020 - 20:49

I referred back to BSG's Articulation plugin and noticed that it used these so gave them a try. Luckily for me it was the solution. I remember wondering what they were for; well now I have a better idea.

jeetee

• Sep 26, 2020 - 20:54

They manage the "undostack", meaning everything between startCmd and endCmd is what is considered a single edit, and also what will be undone when you trigger undo afterwards.

ColorVoices doesn't call that, as for non-gui plugins the engine by default wraps them in a start/endCmd.

yonah_ag

• Sep 26, 2020 - 21:10

Neat. Now I understand.