test numbering system: I would prefer to name my tests after issue# instead of using sequential numbers.
The convention in mtest is that the tests (at least for repeat and clefs) is to use sequential numbers, eg: repeat01, repeat02, ... or clef_courtesy01 clef_courtesy02 ...
If I am working on a few different related issues and am making different PRs for the same class, then I would like for the test case naming scheme to not clash when pushing. So I would prefer to name my tests using the issue name in the test title instead of sequential numbers, such as clef_courtesy_78196 for instance to refer to a courtesy clef test for issue #78196. Then maybe if I have multiple tests for that issue, I could start appending a number after that, like clef_courtesy_78196_01, clef_courtesy_78196_02
Is this ok if I do this?
Comments
for example in https://github.com/musescore/MuseScore/pull/2223/files I've named the test function:
"void clef_courtesy_78196()"
and the corresponding test file:
"clef_courtesy_78196.mscx"
Since I already have an outstanding PR with test named clef_courtesy03 I don't want to call this test clef_courtesy04 in case that prior outstanding PR is rejected.
In reply to for example in by ericfontainejazz
All fine for me. Naming a specific test for a specific issue with the issue number sounds good.