Bar line alignment in normal and small staves
If a score contains both normal and small staves, bar lines are horizontally scaled and aligned as in this screen shot:
In practice, for scaling:
- End bar lines are drawn with the same width in both normal and regular staves
- All other kinds of bar lines are horizontally scaled down (made small) in small staves
And for alignment:
- For end bar lines, being all of the same widths, alignment does not matter
- All other kinds are always left aligned.
______________________________
1) Is this intentional?
2) If it is not intentional, would it not be the case to:
2a) make small the end bar line too,
2b) left align the start repeat bar line, right align the end bar line and the end repeat bar line and centre align all other kinds? (the extra staff protruding from the small end repeat at the end of the first staff is particularly ugly, isn't it?)
Thanks,
M.
Prisegtukas | Dydis |
---|---|
test_barline_align.png | 10.13 KB |
Komentarai
Good points! I don't have a lot of this type of music on hand, but the examples I could find - including the ones scattered about in Gould's "Behind Bars" - suggest the most common thing is to simply not scale any of the barlines. Ending and double bars were rarely scaled. Unfortunately, I haven't yet found any examples of repeat bars in this context. Either not scaling them at all, or right aligning the end repeat, definitely makes sense to me.
EDIT: perusing IMSLP, I see at least as many examples where the barlines *are* scaled. In particular, I did find some repeats, and they were scaled down (and right aligned for the end repeat). I don't know how these are drawn; it seems they might have to be scaled to get the dot spacing right, but maybe those are drawn separately.
Its a bug. For width calculation of end barline scrore()->spatium() is used, for repeats and others staff()->spatium().
I think it makes sense to draw the barlines in small and normal staves with the same width. If we make them smaller in small staves it might look worse.
Thanks to both for your comments. I have prepared two fixes:
The first fix is nice looking (at least I hope it is!):
This is how the above example looks with this solution:
NOT FOUND: 1
The second fix is cheap:
This is how the above example looks with this solution:
NOT FOUND: 2
About to push PR's to github; then I'll leave to the PTB to choose.
Thanks,
M.
In reply to Thanks to both for your by Miwarre
PTB? I like the 1st better
In reply to Thanks to both for your by Miwarre
I like #1 better too, but I have to admit my examination of published literaure suggests #2 might be somewhat more common. I'm fine with either, and to me, since you've already written the code, they are both equally "cheap" :-)
In reply to I like #1 better too, but I by Marc Sabatella
Add both and make it a style option?
In reply to I like #1 better too, but I by Marc Sabatella
Add both and make it a style option? 'Scale barlines to staff size' or some such?
In reply to Add both and make it a style by Jojo-Schmitz
Ah, finally got it! PTB="powers that be". Never seen that before.
In reply to Add both and make it a style by Jojo-Schmitz
I would have suggested that, but i don't know if it is doable...
as the both are written (and just need to integrate with choice) it let the possibility to everyone to choose.....
Marc seems to have seen both possibilities in edited music, so , let user's choice.... ;)
In reply to I would have suggested that, by Zynette
As far as I can see both have been implemented now, including a style setting to switch between them.
In reply to As far as I can see both have by Jojo-Schmitz
I will try this week end,
and later should we documented it (in layout and formatting ?)