Master Pallets causing Runtime failure.
This is an issue I've had since upgrading musescore to 2.0 on Windows 7, when it launched but I only just figured out the cause, mind you this issue is minor for me because all I use master pallets for is custom time signatures. With musescore 2.0.3 I reset to factory and found the master pallets were no longer causing an issue, then I customized my settings how I like and lost the pallets again, so I reset and changed my settings restarting musescore and opening master pallets to find that what was causing it was a custom instruments file I made editing the original file to have the instruments sorted how I prefer, I was wondering if anyone could perform any insight on why an edited instruments file could cause the master pallets to crash musescore, it would be much appreciated. The error message states.
Microsoft Visual C++ Runtime Library
This application has requested the Runtime to terminate it in an unusual way.
Please contact this application's support team for more information.
And for reference I am attaching my instrument file.
| Attachment | Size |
|---|---|
| instruments-edit.xml | 448.31 KB |
Comments
Please provide exact steps how to reproduce the crash. Just adding your intriments.xml file doesn't cause a crash for me
In reply to Please provide exact steps by Jojo-Schmitz
Okay, I'll start with resseting to factory settings (just to be positive it isn't something else).
Open MuseScore
View-->Master Pallet...
Master Pallet Opens
Edit-->Preferences
Go to "Score" tab
Set "instruments-edit.xml" for Instrument list 1
OK
Close MuseScore
Open MuseScore
View-->Master Pallet
Crash.
If that isn't causing a crash for you, perhaps there's something wrong with my computer or the C++ Runtime Library. Also I forgot to mention my OS, Windows 7, I'll edit that in my OP for others to see as well.
In reply to Okay, I'll start with by jason_pilla
OK, confirmed. I had first used it as the 2nd list.
It aborts with a qFatal(), famous last words:
Fatal: Did not find instrument (...\MuseScore\libmscore\mcursor.cpp:161, void Ms::MCursor::addPart(const QString&))
In reply to OK, confirmed. I had first by Jojo-Schmitz
That's unfortunate, I was kind of hoping it was old laptop and not a bug in MuseScore, because I love MuseScore, but I suppose the first step to fixing something is to know what's causing it, best of luck to you or whomever fixes the crash.
In reply to OK, confirmed. I had first by Jojo-Schmitz
Does that mean it's looking for an instrument I edited out of the file?
In reply to Does that mean it's looking by jason_pilla
Yes, that's what it Looks like, in order to generate the time sig palette it creatd a part for 'voice', this doesn't exist -> Crash
Stack trace (in master)
1 Ms::MCursor::addPart mcursor.cpp 161 0x8f8e60
2 Ms::NoteGroups::createScore noteGroups.cpp 35 0x5fdbe4
3 Ms::NoteGroups::setSig noteGroups.cpp 100 0x5fe289
4 Ms::TimeDialog::TimeDialog timedialog.cpp 69 0x4d7b12
5 Ms::MasterPalette::MasterPalette masterpalette.cpp 147 0x5c668e
6 Ms::MuseScore::showMasterPalette masterpalette.cpp 59 0x5c60f2
7 Ms::MuseScore::cmd musescore.cpp 4146 0x4991c6
8 Ms::MuseScore::cmd musescore.cpp 3994 0x498668
9 Ms::MuseScore::qt_static_metacall moc_musescore.cpp 820 0x689210
10 ZN11QMetaObject8activateEP7QObjectiiPPv 0x68a655a2
11 ZN12QActionGroup7hoveredEP7QAction 0x61dc4b95
12 ?? 0x1faf4da0
13 ZN7QAction8activateENS_11ActionEventE 0x61dc3b6e
14 ?? 0x28c928
15 ?? 0x24748b04
16 ?? 0x74f68510
17 ?? 0x89068b28
18 ?? 0xfff189cb
19 ?? 0x74d83910
20 ?? 0x85108b12
...
In reply to Yes, that's what it Looks by Jojo-Schmitz
Okay, I'll try editing 'voice' back in as an instrument and see if that makes any difference, though I would assume if it happens for that it could happen for several other instruments.
In reply to Okay, I'll try editing by jason_pilla
there's only one addPart() call in the code, and it uses "voice" as ist Argument. There are a few more in the testing code (there using "voice" and "electric-guitar"), but this won't affect MuseScore as a program, just when using it for tests
Might be worth a comment in the XML file to not remove this
In reply to there's only one addPart() by Jojo-Schmitz
I see, and I agree, I would hate for someone to suffer the same consequence that I have.
In reply to I see, and I agree, I would by jason_pilla
see https://github.com/musescore/MuseScore/pull/2527
In reply to Yes, that's what it Looks by Jojo-Schmitz
And confirmed, I copied the 'voice' out of instrument group 'vocals' into 'Vocals - solo" in my edited file and the crash stopped occurring, edited it back out the edited file, crash, edit back in, runs fine, thank you for the help.