Plugin functionnality lost in 3.0
I'm currently working with the Plugin API and I encountered an issue regarding the method Cursor::addNote
The issue is the same as described in the thread cursor.addNote doesn't update internal segment reference
The fix #100181: cursor.addNote doesn't update internal segment reference was lost during a refactor when the plugin API was moved from libmscore/ to the mscore/plugin/ folder.
I forked the project and reimplemented the fix, I was wondering how should I proceed to commit my changes and open a PR.
Should I re-open the issue or create a new one ?
Comments
Reopening #100181: cursor.addNote doesn't update internal segment reference is not the way to go, it is way too old and got fixed too long ago in 2.x, better create a new issue for 3.x.
You may want to wait for 3.2, which has quite a bunch of added plugin APIs, resp. base your changes on top of latest master. Other than that: of course a PR is welcome
In reply to Reopening #100181: cursor… by Jojo-Schmitz
Are you suggesting I PR on the 3.2 branch ? Or do I wait until it is merged into master ?
In reply to Are you suggesting I PR on… by Sonny-Kl
Neither
3.2 will not get merged into master.
Work on the master branch.
In reply to Neither 3.2 will not get… by Jojo-Schmitz
Ok thanks
Create a new issue, mark it as a regression and link it to the old one by adding a comment (after creation) containing [#100181]
As for making a PR, see the git workflow at https://musescore.org/en/handbook/developers-handbook/finding-your-way-… and make sure to sign our CLA (http://musescore.org/cla) if you haven't already
In reply to Create a new issue, mark it… by jeetee
Yes I did check the git forklow and cla, thanks for the answer