Musescore 3 Crashing

• Mar 13, 2020 - 10:12

I have iOS 10.15.3 and everytime I add a an instrument and say OK, it closes unexpectedly. Please can someone help me sort this out ASAP.

Comments

Jojo-Schmitz

• Mar 13, 2020 - 10:14

What version of MusyeScore exactly, and can you share the score you're trying to an instrument to?

williamsilk1

• Mar 13, 2020 - 10:18

Hello, version 3,4,1,2501

williamsilk1

• Mar 13, 2020 - 10:28

Trying to add a bassoon and a French horn

Attachment	Size
Mission Impossible Michaelhouse.mscz	182.51 KB

Jojo-Schmitz

• Mar 13, 2020 - 10:34

No problem adding a Bassoon, or any Horn (there is none by the name of French Horn though)
MuseScore 3.4.2, Windows 7

Edit: darn, adding a Horn in F and I get a crash
Edit 2: and now with Bassoon too, strange

Firering up a debug build now...

Jojo-Schmitz

• Mar 13, 2020 - 10:58

Inititial observation, loading that score into a debug build I get the following message many times:

Warning: reorderMidiMapping: no part in master score is linked (...\libmscore\midimapping.cpp:146, void Ms::MasterScore::rebuildExcerptsMidiMapping())

Looks suspicious somehow, and related to the score/part relationship

Adding Bassone on hitting OK I get this stack trace:

1 QListData::begin qlist.h 118 0xfa902c
2 QList::begin qlist.h 339 0xf92f9c
3 Ms::MuseScore::editInstrList instrdialog.cpp 521 0x702a73
4 Ms::MuseScore::cmd musescore.cpp 6012 0x42f3d4
5 Ms::MuseScore::cmd musescore.cpp 5842 0x42e6c7
6 Ms::MuseScore::qt_static_metacall moc_musescore.cpp 514 0x633e2d
7 void doActivate(QObject *, int, void * *) 0x68be03cd
8 QActionGroupPrivate::_q_actionTriggered() 0x2bee4da2
9 QActionGroup::qt_static_metacall(QObject *, QMetaObject::Call, int, void * *) 0x2bee5359
10 void doActivate(QObject *, int, void * *) 0x68be03cd
11 QAction::activate(QAction::ActionEvent) 0x2bee3e2a
12 QAction::event(QEvent *) 0x2bee490b
13 QApplicationPrivate::notify_helper(QObject *, QEvent *) 0x2bee7a10
14 QApplication::notify(QObject *, QEvent *) 0x2beee543
15 QCoreApplication::sendEvent(QObject *, QEvent *) 0x68a975b9
16 QShortcutMap::dispatchEvent(QKeyEvent *) 0x619abb06
17 QShortcutMap::tryShortcut(QKeyEvent *) 0x619ac5e9
18 QWindowSystemInterface::handleShortcutEvent(QWindow *, unsigned long, int, QFlags, unsigned int, unsigned int, unsigned int, QString const&, bool, unsigned short) 0x61956d10
19 QGuiApplicationPrivate::processKeyEvent(QWindowSystemInterfacePrivate::KeyEvent *) 0x61974c35
20 QGuiApplicationPrivate::processWindowSystemEvent(QWindowSystemInterfacePrivate::WindowSystemEvent *) 0x61979505
...

Code at stack level 3 is that inner for loop:

                  for (Staff* s : sl) {
                        const LinkedElements* sll = s->links();
                        for (auto le : *sll) {

With sll being 0, so a null pointer gets dereferenced -> kaboom!
So indeed related to links between score and parts.

Jojo-Schmitz

• Mar 13, 2020 - 11:28

band aid for that crash is to check for nullptr before using it:

                  for (Staff* s : sl) {
                        const LinkedElements* sll = s->links();
                        if (!sll)
                              break;
                        for (auto le : *sll) {

Jm6stringer

• Mar 13, 2020 - 11:07

Also crashes MuseScore 3.3.4
(I haven't upgraded yet.)
Deleting all the parts allows adding instruments without the crash.

Jojo-Schmitz

• Mar 13, 2020 - 11:10

Indeed, see below
Crashes in latest master too

Jojo-Schmitz

• Mar 13, 2020 - 10:43

I can add instruments if first removing all parts.
A first possible workaround...

Jojo-Schmitz

• Mar 13, 2020 - 11:09

Score with recreated parts

Attachment	Size
Mission Impossible Michaelhouse-fixed.mscz	133.54 KB

Jojo-Schmitz

• Mar 13, 2020 - 10:45

How did you create that score? Almost all date in File > Score Properties is empty, including Platform and Creation date, which are automatically filled on score creation

Jojo-Schmitz

• Mar 13, 2020 - 11:05

So this brings us back to this question
Looking deeper into that score seems to show that it had been imported from an earlier version of MuseScore, I guess MuseScore 1.x (which didn't have linked parts)
Is that the case? Do you still have the score before importing it into 3.x?

williamsilk1

• Mar 13, 2020 - 11:32

yes it was created ages ago with early musescore. my orchestra is growing and wanted to resurrect this piece.

ok thank you will redo each part.

thank you

Jojo-Schmitz

• Mar 13, 2020 - 11:36

Can you share the old version? Needed to make sure we can fix that crash the right way.
Also please tell us what you did to is after the import, as detailed as possible

Jojo-Schmitz

• Mar 13, 2020 - 12:17

Culprit seems to be the 2nd Dwarsfluit part (why 2 of them?), so removing just that prevents/avoids the crash already.

Jojo-Schmitz

• Mar 13, 2020 - 10:29

There is 3.4.2 available meanwhile, but I don't see it to fix an issue that looks like your's, see https://musescore.org/en/handbook/developers-handbook/release-notes/rel…

Jojo-Schmitz

• Mar 19, 2020 - 13:08

Crash fixed in the latest development build and as such in next release