MuseScore4.2.1 musicXML Import ignores ('editorial') <accidental> attribute 'parentheses'

• Mar 5, 2024 - 15:42

the here attached test file musicXML.Test3.ed.musicxml was created by manually editing (with Windows Wordpad) an uncompressed musicXML file previously exported from MuseScore4.

The original file was edited to modify <accidental>sharp</accidental> declarations thus:
<accidental editorial="yes" parentheses="no">sharp</accidental>

When MuseScore4 opens musicXML.Test3.ed.musicxml, it displays all sharps with parentheses, but I would expect the sharps to be displayed without parentheses (which is what I want).

Attachment	Size
musicXML.Test3_.ed_.musicxml	10.25 KB
musicXML.Test3_.Capture.JPG	70.2 KB

Comments

Jojo-Schmitz

• Mar 5, 2024 - 16:54

Confirmed. Please report on GitHub, https://github.com/musescore/MuseScore/issues/new/choose, it seems to be a regression vs. MuseScore 3.6.2

JoeWheee

• Mar 6, 2024 - 21:38

Thank you. I have never used GitHub before. I have created a account and reported the Issue as best I could. I hope that is sufficient.
While I was typing on GitHub, a reference to an apparently similar problem popped up
https://github.com/musescore/MuseScore/pull/21835
I did not know how best to use the popup, so I just included the information in my report.
Incidentally, I could see a provision on the GitHub UI for including pasted info (eg a small graphic), but I could not see a function there for uploading data file(s).

Jojo-Schmitz

• Mar 6, 2024 - 21:51

That's not an issue, but a pull request, supposed to fix an issue.

Edit: Ah, I see, it is at https://github.com/musescore/MuseScore/issues/21847, thanks!

Jojo-Schmitz

• Mar 5, 2024 - 17:00

Seems currently by design though:

    if (type != AccidentalType::NONE) {
        auto a = Factory::createAccidental(score->dummy());
        a->setAccidentalType(type);
        if (cautionary || parentheses) {
            a->setBracket(AccidentalBracket(AccidentalBracket::PARENTHESIS));
            a->setRole(AccidentalRole::USER);
        } else if (editorial || bracket) {
            a->setBracket(AccidentalBracket(AccidentalBracket::BRACKET));
            a->setRole(AccidentalRole::USER);
        }
        if (accColor.isValid()) {
            a->setColor(accColor);
        }
        return a;
    }

since https://github.com/musescore/MuseScore/pull/19132

bobjp

• Mar 5, 2024 - 17:23

In a test file of my own, I did this. Created a score with parentheses around an accidental. Saved as musicxml. Opened the xml in an editor and did not do the same modification you did. I only changed the "yes" to "no". Saved the new file. The parentheses where gone.

Jojo-Schmitz

• Mar 5, 2024 - 19:04

MuseScore's MusicXML export does not create these editorial="yes" and cautionary="yes" properties, just bracket="yes" and parentheses="yes", that's why your test doesn't show the issue. That'd need to get fix along with the OP's issue

bobjp

• Mar 5, 2024 - 23:44

I know I'm out of my element, here. What was the point of adding the "editorial" lines? He made it sound like it was to either get rid of the parentheses, or to demonstrate that MU4 just ignored them. Yes, MU4 ignored them. But did it need them.

On the other hand, did you open the posted xml? There are no parentheses. Only brackets. When I open an unzipped version in notepad, brackets are mentioned. When I change the "yes" to "no", brackets go away.

Jojo-Schmitz

• Mar 5, 2024 - 17:30

Changing the above code to

    if (type != AccidentalType::NONE) {
        auto a = Factory::createAccidental(score->dummy());
        a->setAccidentalType(type);
        if (parentheses) {
            a->setBracket(AccidentalBracket(AccidentalBracket::PARENTHESIS));
            a->setRole(AccidentalRole::USER);
        } else if (bracket) {
            a->setBracket(AccidentalBracket(AccidentalBracket::BRACKET));
            a->setRole(AccidentalRole::USER);
        } else if (cautionary || editorial) {
            a->setRole(AccidentalRole::USER);
        }
        if (accColor.isValid()) {
            a->setColor(accColor);
        }
        return a;
    }

should fix this

Jojo-Schmitz

• Mar 5, 2024 - 17:36

Your example would be more convincing with a key signature that really makes these accidentals optional (AKA cautionary/editorial)

JoeWheee

• Mar 6, 2024 - 21:52

Yes, you are right, it would. However the score from my "real application" which I want Musescore to render correctly is not intended to be Common Western Music Notation. It will be an approximation to "Griffschrift" for interpretation by a musician playing a "diatonic Accordion". Musescore provides a convenient mechanism to get my (musicXML) score rendered and exported to PDF. I chose "editorial" rather than "cautionary" for the accidentals on the premise that a human editor can in principle write whatever they want on the score.

Jojo-Schmitz

• Mar 6, 2024 - 21:59

What also threw me off in my developing and testing the fix was that you combined "editorial" and "parentheses", whild I thought it should be "bracket" there (and "parentheses" with "cautionary").
I believe my fix now covers that too ;-)

JoeWheee

• Mar 6, 2024 - 22:40

Sorry I am a bit slow in responding to your emails and postings here.
I am really new to the topic of XML. I got the idea to combine 'parentheses' with 'editorial' from:
https://w3c.github.io/musicxml/musicxml-reference/elements/accidental/
I really appreciate your following up my problem so promptly!

JoeWheee

• Mar 6, 2024 - 22:44

I need to close down now (it is nearly midnight here), so I'll catch up with this thread again tomorrow.

Jojo-Schmitz

• Mar 7, 2024 - 07:11

Here too (Germany)

Jojo-Schmitz

• Mar 7, 2024 - 07:11

It is certainly allowed, just didn't match my expectations

Jojo-Schmitz

• Mar 6, 2024 - 09:12

See https://github.com/musescore/MuseScore/pull/21835