Moving soundfont in soundfont selector creates duplicate list entries

• Sep 22, 2018 - 10:55
Reported version
3.0
Priority
P0 - Critical
Type
Functional
Severity
S2 - Critical
Status
closed
Regression
No
Workaround
No
Project
MuseScore

Commit: 94594acc7421f6475ce3518ece93391865c0b89f
Steps to reproduce:
1.: View -> Synthesizer -> Fluid tab
2.: If only 1 soundfont, add multiple others
3.: Use the up/down buttons to move soundfont

Result: Element is moved, and size of list grows. Expected: Element is moved.

Note that this happens not only when using QList::swap (like the up/down buttons), but also when using QList::move.

Comments

• Dec 4, 2018 - 10:25
Severity S4 - Minor ⇒ S2 - Critical
Priority ⇒ P0 - Critical
Regression ⇒ No
Workaround ⇒ No

I can reproduce if number of elements is bigger than two.

Reply

• Dec 12, 2018 - 09:37
Status active ⇒ fixed

Fixed in branch master, commit 87ed9ac474

fix #276456: Moving soundfont in the soundfonts list creates duplicate list entries (Fluid)

Call removeSoundfonts() before rebuilding the list.
Refactor code in Up/Down methods for both Fluid and Zerberus.

Reply