"Bubly" misspelled? GunChleoc • May 1, 2017 - 21:18 Reported version 2.1 Type Functional Severity S5 - Suggestion Status closed Project MuseScore Is "Bubly" a bubbly note / darado embellishment? Looks misspelled. Occurrences: ../../libmscore/bagpembell.cpp:162;../../libmscore/bagpembell.cpp:219 Reply Comments Jojo-Schmitz • May 1, 2017 - 23:35 We could temporarily fix it in the en_US (and en_GB) translations, if we knew what it is supposed to be... Reply Jojo-Schmitz • May 2, 2017 - 06:08 There is a comment in the code: // Birl, Bubly, D Throws (continued) and Taorluaths (continued) and later // Bubly So if this is a typo, it is in there 4 times. But a Google search seems to indicate that indeed it should be "Bubbly" Reply Jojo-Schmitz • May 2, 2017 - 06:11 Status (old) active ⇒ patch (code needs review) See https://github.com/musescore/MuseScore/pull/3161 Here too temporarily fixed in the en_US (and en_GB) translation Reply Git Message • May 26, 2017 - 10:03 Status (old) patch (code needs review) ⇒ fixed Fixed in branch master, commit d365015698 fix #195421: "Bubly" misspelled Reply Git Message • May 26, 2017 - 10:11 Fixed in branch 2.2, commit 55d2b60160 fix #195421: "Bubly" misspelled Reply Jojo-Schmitz • May 31, 2017 - 15:04 Reported version 2.2 ⇒ 2.1 Reply System Message • Jun 14, 2017 - 15:05 Status (old) fixed ⇒ closed Automatically closed -- issue fixed for 2 weeks with no activity. Reply
Jojo-Schmitz • May 1, 2017 - 23:35 We could temporarily fix it in the en_US (and en_GB) translations, if we knew what it is supposed to be... Reply
Jojo-Schmitz • May 2, 2017 - 06:08 There is a comment in the code: // Birl, Bubly, D Throws (continued) and Taorluaths (continued) and later // Bubly So if this is a typo, it is in there 4 times. But a Google search seems to indicate that indeed it should be "Bubbly" Reply
Jojo-Schmitz • May 2, 2017 - 06:11 Status (old) active ⇒ patch (code needs review) See https://github.com/musescore/MuseScore/pull/3161 Here too temporarily fixed in the en_US (and en_GB) translation Reply
Git Message • May 26, 2017 - 10:03 Status (old) patch (code needs review) ⇒ fixed Fixed in branch master, commit d365015698 fix #195421: "Bubly" misspelled Reply
Git Message • May 26, 2017 - 10:11 Fixed in branch 2.2, commit 55d2b60160 fix #195421: "Bubly" misspelled Reply
System Message • Jun 14, 2017 - 15:05 Status (old) fixed ⇒ closed Automatically closed -- issue fixed for 2 weeks with no activity. Reply
Comments
We could temporarily fix it in the en_US (and en_GB) translations, if we knew what it is supposed to be...
There is a comment in the code:
// Birl, Bubly, D Throws (continued) and Taorluaths (continued)
and later
// Bubly
So if this is a typo, it is in there 4 times.
But a Google search seems to indicate that indeed it should be "Bubbly"
See https://github.com/musescore/MuseScore/pull/3161
Here too temporarily fixed in the en_US (and en_GB) translation
Fixed in branch master, commit d365015698
fix #195421: "Bubly" misspelled
Fixed in branch 2.2, commit 55d2b60160
fix #195421: "Bubly" misspelled
Automatically closed -- issue fixed for 2 weeks with no activity.