Crash on undo of instrument deletion

• Aug 13, 2013 - 22:25
Type
Functional
Severity
S2 - Critical
Status
closed
Project

tuxg_example.gp5

1 - open the .gp5 file
2 - Insert > Instrument
3 - select an instrument
4 - delete
5 - ok
6 - undo*
7 - crash

* or save and reopen

win 8 - MuseScoreNightly-2013-08-13-2025-10b2a88

Attachment Size
tuxg_example.gp5 2.32 KB

Comments

Other info, maybe useful for developers:

1 - open the original .gp5 and save in uncompressed musescore format tuxg_example1.mscx
2 - delete an instrument and save with different name tuxg_example1a.mscx
3 - now re-opening the file, crash
4 - what the differences between the files:

analysing the file tuxg_example1a have 3 part, 3 instr. .. but 4 scores

manually deleting the 4th score (the unwanted intstr, deleted before), the file open without crash tuxg_example1b.mscx

still some bug in deletion process: this will cause a file corrupted

Attachment Size
tuxg_example1.mscx 28.04 KB
tuxg_example1a.mscx 25.76 KB
tuxg_example1b.mscx 22.13 KB

I'm testintg MuseScoreNightly-2013-08-14-1709-2d255a4 on win8:

the problem seems to be solved for the example above,
but persists for more complex files

please try this tuxg_example_full.gp5

open the gp5 and saving in musescore format before modify not help

but exporting in xml and re-open the xml will be fine: deletion and other op., like undo, are allowed

the problem's still the score not deleted

Attachment Size
tuxg_example_full.gp5 43.49 KB
Title Crash on undo of instrument deletion Crash on undo of instrument deletion

Hi

I wonder if it's Guitar Pro exclusively?

I might have encountered this a few weeks ago.

Hi
yes there was the same problem reported to midi files, which has been fixed.

"Crash on undo of staff bracket deletion" Fixed in e4012586b2

The same sample file, but in midi format, it works correctly, tuxg_example_full.mid
so i think may be a problem with the import format gp5 from tuxguitar.
Working for years with tuxguitar and now I'd like to transfer my files in musescore 2.0,
so I'm testing the import process of the gp5 tuxguitar format
In fact there are other operations that cause crashes, like insert a clef and undo,
but I would like to report a problem at a time, and maybe it could be related

the most serious problem, even more than the crash (!), is that the file, edited and saved,
will be corrupted and not recoverable (compressed format) in any way.

Attachment Size
tuxg_example_full.mid 26.15 KB

So, i think, here we need a compatibility check of the file before saving. Apart from this particular case (import format gp5), the problem may recur on other occasions, resulting in the loss of the file