MIDI import panel not translatable Jojo-Schmitz • Oct 29, 2013 - 11:40 Type Wording/Translation Severity S4 - Minor Status closed Project MuseScore The strings from the MIDI import Panel are not translatable. Most probably due to the lack of not using tr() and/or QT_TRANSLATE_NOOP() Reply Comments Thomas • Oct 29, 2013 - 12:22 Feel free to add a pull request. Reply Jojo-Schmitz • Oct 29, 2013 - 12:24 I looked at it, but I'm not really sure which of the strings are to be translated and which don't, as they may have to match something from the MIDI file. I'll certainly have another look, but trig-ger is aware of this issue too... Reply trig-ger • Oct 29, 2013 - 12:31 I can try to add the tr() because I looked at the code of the MIDI panel a lot. [This evening or at the end of the week, if it is OK] Reply Jojo-Schmitz • Oct 29, 2013 - 12:33 Take your time. I just created this issue for it to not get forgotten Reply [DELETED] 5 • Nov 15, 2013 - 08:03 Status (old) active ⇒ fixed This should be fixed. See df1f92a45b Reply System Message • Nov 29, 2013 - 08:05 Status (old) fixed ⇒ closed Automatically closed -- issue fixed for 2 weeks with no activity. Reply
Jojo-Schmitz • Oct 29, 2013 - 12:24 I looked at it, but I'm not really sure which of the strings are to be translated and which don't, as they may have to match something from the MIDI file. I'll certainly have another look, but trig-ger is aware of this issue too... Reply
trig-ger • Oct 29, 2013 - 12:31 I can try to add the tr() because I looked at the code of the MIDI panel a lot. [This evening or at the end of the week, if it is OK] Reply
Jojo-Schmitz • Oct 29, 2013 - 12:33 Take your time. I just created this issue for it to not get forgotten Reply
[DELETED] 5 • Nov 15, 2013 - 08:03 Status (old) active ⇒ fixed This should be fixed. See df1f92a45b Reply
System Message • Nov 29, 2013 - 08:05 Status (old) fixed ⇒ closed Automatically closed -- issue fixed for 2 weeks with no activity. Reply
Comments
Feel free to add a pull request.
I looked at it, but I'm not really sure which of the strings are to be translated and which don't, as they may have to match something from the MIDI file.
I'll certainly have another look, but trig-ger is aware of this issue too...
I can try to add the tr() because I looked at the code of the MIDI panel a lot.
[This evening or at the end of the week, if it is OK]
Take your time. I just created this issue for it to not get forgotten
This should be fixed. See df1f92a45b
Automatically closed -- issue fixed for 2 weeks with no activity.