Hang when adding time signature
The app hangs when adding time signatures to some scores. These are scores with multiple time signatures and measures beyond the location where I'm adding the new time signature.
I'll try to get a reduction that reproduces. In the meantime, see attached sample dump.
MacOS 10.9.1
| Attachment | Size |
|---|---|
| hang.txt | 78.16 KB |
Comments
I took a look at the hang and noticed the callout for "repeat". I had some single measure repeat signs in the score after the time signature and, if I remove them, the app does not hang.
So, it seems to hang if there are single measure repeats after the insertion point.
Confirmed. Create score, add a measure repeat symbol to measure 4, try to add a time signature change to measure 2: hang.
I wonder what expected behavior would be? I guess ideally, MuseScore would take the contents of the previous measure and use those as the basis for rewriting the measure containing the measure repeat. I'm sure that's doable.
Meanwhile, a much lamer but simple fix is to just treat this as full measure rest, which is basically how it is represented internally anyhow.
Fixed to no longer hang in https://github.com/musescore/MuseScore/pull/658
Someone else can worry about whether to actually find a clever way to rewrite the measures. All my fix does is treat the measure repeat sign like a rest, which is actually how it is implemented under the hood.
Fixed in https://github.com/musescore/MuseScore/commit/2c2b21a0a056302f608c8fa7c…
Automatically closed -- issue fixed for 2 weeks with no activity.