Toolbar customization refinements & fixes (including customize page view / zoom element)
At the moment it's not possible to customise the Page View element of the File Operations toolbar. I accidentally discovered this when, err, trying to customise my ToolBar. I wanted to get rid of everything but the Page View element. (And it turns around that for this ONE case there's a workaround - removed everything else form the File Operations toolbar and then you've just got Page View.) But, from user point of view, it's an odd limitation. It would seem reasonable to want to do something like this:
I've had a look at the code to do a proof of concept. The reason that Page View element wasn't made customisable in the first place is because unlike everything else on the ToolBar its not a button (a QTButton) - rather it's two drop down boxes (QComboBox x 2) next to each other. So it's an exception and the code treats it as such.
I've modified the code to make the exception a bit smarter and so I can successfully customise the Toolbar as per this suggestion - which is how I created the screenshots here.
I've not yet figured out a coherent way to prevent my fix from zapping the Page View element form the Basic and Advanced toolbar, something that would be a less than desirable outcome. (Can any devs point me in the right direction and save me digging around too much? Appreciated if you can :).)
If I can sort that out and create/select an icon for use in the customise toolbar dialogue then I can generate a PR for this. (Or, if it's acceptable etiquette, put my work in progress PR up??)
While looking into this I also spotted a couple of minor issues with the toolbar customisation:
It appears that SPACERS are not saved when modifying the toolbar. They appear when you customise but are then lost if you change workspace and go back.
The terms used in the customisation dialogue are internal text strings. So all lower case with dashes. Not very user friendly. And they don't respect translation. (Or is it that they do nut they just haven't been translated yet... I don't understand the translation mechanism very well as yet.)
The UI could do with a bit of attention, not least obvious things like the customisation dialogue box having a less zany title than "Dialogue". Possibly more controversial would be swapping the order of the columns to Toolbar: Available Actions: Actions - that's a much more common (near universal??) ordering for such things and follows a more general principle of going from less to more specific.