Changing some score settings don't make score 'dirty'

• Jul 7, 2019 - 12:19
Reported version
3.2
Priority
P2 - Medium
Type
Functional
Frequency
Once
Severity
S2 - Critical
Reproducibility
Always
Status
duplicate
Regression
No
Workaround
No
Project

Changing the settings View > Show invisible, Show unprintable, Show frames, Show page borders and Show irregular measures don't mark the score dirty, so closing the score doesn't warn about losing changes.

This is losing information, hence marking Critical.

Changing those settings is not undoable either.


Comments

Priority P2 - Medium

It's only lost if you don't save your score, though, and this isn't really critical information, and it's simple enough to reestablish. So I don't really think it's that appropriate to consider this critical. Worth further clarification in the issue tracker instructions, I think.

FWIW, "not undoable" is pretty much the same as "doesn't mark score dirty" - the presence of an undo stack is how we check for dirty. I'm not convinced these should be undoable - they are view changes more than score changes, much like zoom setting or page/continuous view (which also doesn't mark score dirty). But since they are saved, they should somehow also mark the score dirty.

Zoom settings are not saved into a score, page vs. continuous mode though is, so should mark score dirty. And if making these undoable is the way to mark a score dirty, so be it.

Regarding making the operation undoable - that's how it was in MuseScore 2, but that was lame, because it meant undoing "real" changes would also flip these settings you really didn't want to undo. Better would be to track dirty status using this info as well as the undo stack.