High Floor Tom in 2nd voice by default
Reported version
3.4
Type
Functional
Frequency
Few
Severity
S4 - Minor
Reproducibility
Always
Status
PR created
Regression
No
Workaround
No
Project
To reproduce:
1. Add Drumset as an Instrument.
2. Press N to enter drumset input mode.
3. High Floor Tom (MIDI note #43, G2, between Closed & Pedal Hi-Hat) is assigned to the 2nd (foot) voice, in green & with the stem down.
(Alternatively, check its entry in Edit Drumset)
This inconsistent with the other floor tom (#41), all other toms, and all other parts of the kit struck with sticks - which belong in the 1st voice.
I have already fixed it in drumset.cpp and updated the templates ; will submit a PR shortly.
Comments
PR: https://github.com/musescore/MuseScore/pull/5752/commits/dbc36678f968e9…
Haven't touched files in the *test directories, not sure if necessary.
(Am I doing this correctly? It's my 1st PR, so please tell me if I could do something better! ;) )
Yes, you'd neet to look after the failed tests