Collision avoidance remains ON when barlines are hidden in "Staff/Part Properties"
Reported version
3.4
Priority
P2 - Medium
Type
Functional
Frequency
Once
Severity
S3 - Major
Reproducibility
Always
Status
active
Regression
No
Workaround
Yes
Project
OS: Windows 10 (10.0), Arch.: x86_64, MuseScore version (64-bit): 3.4.2.9788, revision: 148e43f
- Open the attached file. Note that all staff elements, including barlines, have been made invisible in Staff/Part properties.
- Open Style > Fretboard Diagrams and reduce "Default vertical position" so that the Fret Diagrams move down through the staff.
Expected result: All diagrams move downwards to the same extent.
Actual result: The diagrams above the invisible barlines are blocked.
| Attachment | Size |
|---|---|
| fretboard_diagram_issue.mscz | 3.95 KB |
Comments
It appears that although the bar lines are hidden, collision avoidance for them is still ON when adjusting "Default vertical position" (Style > Fretboard Diagrams). However, if you make the bar lines invisible (shortcut "V"), rather than hiding them via "Staff/Parts Properties", collision avoidance is also turned off and "Default vertical position" works again. (Note: Collision avoidance seems to be OFF when you hide the Clef, Time Sig, Key Sig in "Staff/Part Properties", so, at a guess, it should be the same for barlines).
The workaround is to use the Y-offset in the Inspector to move the diagrams.
True. Looks like the barline is being added to the skyline. It isn't if you instead or in addition actually set the barlines invisible or disable autoplace for them, so that's the better workaround I think.
Barlines are added to the skyline in layout.cpp:
https://github.com/musescore/MuseScore/blob/3.x/libmscore/layout.cpp#L3…
I guess checking the staff property here would fix it, but it also kind of feels like there should be something a bit more global. After all, wouldn't we want then same treatment when suppressing clefs or key signatures or any other elements in staff properties (and I can reproduce the same bug with hidden clef or key signature changes)? Barlines get handled specially in these lines, and time signatures are always skipped (as a hack workaround for some other issue). But everything else is, I think, added a few lines further down in the generic code that applies to all other segment types:
https://github.com/musescore/MuseScore/blob/3.x/libmscore/layout.cpp#L3…
So maybe these elements that can be suppressed in this way should override addToSkyline() to also check the relevant staff property.