Fix vtest/gen.bat olexn • Nov 28, 2014 - 16:54 Type Functional Severity S5 - Suggestion Status closed Project MuseScore Fix visual test for windows. Attachment Size wintestfix.zip 579 bytes Reply Comments Marc Sabatella • Nov 28, 2014 - 21:38 Ah, yes, typos have been lurking there a while. FWIW, I incorporated your changes into an otherwise unrelated PR I just submitted: https://github.com/musescore/MuseScore/pull/1483 I needed to update that file anyhow to add a test, made sense to fix it while I was at it. Reply olexn • Nov 29, 2014 - 08:35 Status (old) patch (code needs review) ⇒ closed Thanks. Reply
Marc Sabatella • Nov 28, 2014 - 21:38 Ah, yes, typos have been lurking there a while. FWIW, I incorporated your changes into an otherwise unrelated PR I just submitted: https://github.com/musescore/MuseScore/pull/1483 I needed to update that file anyhow to add a test, made sense to fix it while I was at it. Reply
olexn • Nov 29, 2014 - 08:35 Status (old) patch (code needs review) ⇒ closed Thanks. Reply
Comments
Ah, yes, typos have been lurking there a while. FWIW, I incorporated your changes into an otherwise unrelated PR I just submitted:
https://github.com/musescore/MuseScore/pull/1483
I needed to update that file anyhow to add a test, made sense to fix it while I was at it.
Thanks.