Courtesy Time & Key Signatures should not display on final measure of section if section break occurs on non-measure MeasureBase
In attached score:
it is not desired to have the courtesy time and key signatures be displayed at the final measure of sections, even if the section break occurs on a non-measure MeasureBase object such as a frame.
Tested on musescore 2.0.2 and latest b376184
Closely related to #78196: Courtesy Clefs should not display on final measure of section if section break occurs on non-measure MeasureBase frame
| Attachment | Size |
|---|---|
| courtesy time sigs should not display if section break on frame.mscz | 7.78 KB |
Comments
I updated title and described to reflect that this issue affects key signatures as well as time signatures.
I'm currently looking into a fix modifying the test for sectionBreak in Score::removeGeneratedElements() to make sure considers non-measure MeasureBase objects.
https://github.com/musescore/MuseScore/pull/2227
I implemented fix inside Score::layoutSystemRow (instead of Score::removeGeneratedElements as I said I would above). I've used same added function Measure::isFinalMeasureOfSection() as my PR for #78196: Courtesy Clefs should not display on final measure of section if section break occurs on non-measure MeasureBase frame.
Fixed in branch master, commit 5f1ec2c513
fix #78216 no courtesy key or time sig if section ends on non-measure
If a section break occurs on a non-measure MeasureBase object such as a vertical or horizontal frame, then the courtesy key or time signature should still not be displayed in the final actual measure of the section.
Fixed in branch master, commit aa648cf6ee
Merge pull request #2227 from ericfont/78216-no-courtesy-key-time-sig-ends-non-measure-layoutSystemRow
fix #78216 no courtesy key or time sig if section ends on non-measure
Fixed in branch 2.0.3, commit df59364717
fix #78216 no courtesy key or time sig if section ends on non-measure
If a section break occurs on a non-measure MeasureBase object such as a vertical or horizontal frame, then the courtesy key or time signature should still not be displayed in the final actual measure of the section.
Automatically closed -- issue fixed for 2 weeks with no activity.