Dots too close on right side of "end-start repeat" barline

• Nov 21, 2010 - 06:27
Type
Functional
Severity
3
Status
closed
Project

Steps to reproduce bug
1. Add a start repeat, end repeat, and end-start repeat to separate measures in a blank score

Expected behavior: Dots should all be the same distance from the thin bar line

Actual behavior: Dots on the right-hand side of the "end-start repeat" barline are closer than any other repeat barline

MuseScore version: 0.9.6.3 stable

(Operating System: Windows 7)

For reference this the code that determines the dot position for start repeats:

            case START_REPEAT:
...
                  double x2   =  lw2 * .5;                               // thick line (lw2)
                  double x1   =  lw2 + d1 + lw * .5;                     // thin line (lw)
                  double x0   =  lw2 + d1 + lw + d1;                     // dot position

The following code determines the dot position for end-start repeats:

            case END_START_REPEAT:
                  {
...
                  double x1   =  dotw + d1 + lw * .5;                                // thin bar
                  double x2   =  dotw + d1 + lw + d1 + lw2 * .5;                     // thick bar
                  double x3   =  dotw + d1 + lw + d1 + lw2 + d1 + lw * .5;           // thin bar
                  double x4   =  dotw + d1 + lw + d1 + lw2 + d1 + lw + dotw * .5;    // dots

I suspect the last line should actually be:

                  double x4   =  dotw + d1 + lw + d1 + lw2 + d1 + lw + d1;    // dots

Comments