Ottava are not respected by piano keyboard when playing
MuseScore 77e980d95d
- Create a score with 8 quarter C notes
- Add ottava in second measure
- Display the keyboard
- Play
Actual result: Piano plays the same note
Expected result: Piano plays one octave higher for the second measure
Comments
The piano display is in pianotools.cpp.
https://github.com/musescore/MuseScore/blob/a9a13687b2d5d67a41e2e0cb2e4…
Thanks, I'm working on it
I was working on this yesterday (forgot to assign myself) and have a fix for the same. @akhilesh If you haven't dived much already, there's no need; I can assign it now and submit a patch if you don't mind.
Sure, I won't go any further
The idea is to feed the playback pitch to the piano key pressing mechanism (along with the offset generated by the ottava) The piano tools code was not taking into account the pitch offset, which was making it neglect the ottava, fixed in this PR :
https://github.com/musescore/MuseScore/pull/2443
Fixed in branch master, commit 0d27c63476
fix #89866: piano keyboard reflects ottava now
Fixed in branch master, commit 5e75f57816
Merge pull request #2443 from shredpub/89866-ottava
fix #89866: piano keyboard reflects ottava now
Fixed in branch 2.0.3, commit 2607d3bddb
fix #89866: piano keyboard reflects ottava now
Automatically closed -- issue fixed for 2 weeks with no activity.