Trill line without tr symbol (code review needed)
I would like to have trill ine without tr symbol.
As my first patch in the project, I've created an implementation in https://github.com/briff/MuseScore/commits/pure_trill_line
If you were so kind to review it, I would be happy to finalize that.
It looks like this:
There are questions:
- do we need to have a separate icon in the toolbar for this type?
- what should be the name (if "pure line" is not appropriate)?
- any other thing to fix? Or better do this with any - optional - symbol?
Thank you,
Bertalan
Attachment | Size |
---|---|
trill_pure_line.PNG | 4.46 KB |
Comments
Could you do a pull request? See Git Workflow
It looks like this feature request has been already done before and the guy named this line a "shake".
See http://musescore.org/en/node/12976
And see also: http://bands.army.mil/masterclass/tusafb/dec2000/jazz.htm ( Search for "shake")
In reply to It looks like this feature by [DELETED] 5
Shake is a fine jazz term for this, but not universal enough to use as the name for this symbol, in my opinion. Any of other suggestions strike me as fine.
The pull request has been merged. The line is called "Pure trill" currently. Anyone has another idea?
In reply to The pull request has been by [DELETED] 5
Finale calls it "trill extension." I guess it is a similar concept to a lyric extension.
In reply to Trill extension by David Bolton
Indeed. Wavy line is also used http://www.finalemusic.com/UserManuals/Finale2012Win/Content/Finale/Tri…
I proposed to use Wavy line in the UI. In particular, we need to add this line in the trill palette, and it also appears in the inspector.
In reply to Indeed. Wavy line is also by [DELETED] 5
Wavy line is good.
In reply to Wavy line is good. by David Bolton
Wavy line it will be. In d54d2df500, it's wavy line in the palette (reset your palette if you don't see it or check Display -> Master palette) and it's wavy line in the inspector. I kept "Pure Line" in the source code.
In reply to The pull request has been by [DELETED] 5
currently it seems to be called 'pure line', not 'Pure trill' (in inspector_trill.ui)