I concur, but am still finding my way around. I am open to guidance.
Is there a header constant which tells me which version of MuseScore import it should be using? Should there be?
Fix #249631: Add SaveAs to PluginCreator
Also changed "New" to generate correct version of import MuseScore
Also added a "Save To:" message while saving.
Fix #249631: Add SaveAs to PluginCreator
Also changed "New" to generate correct version of import MuseScore
Also added a "Save To:" message while saving.
Comments
See https://github.com/musescore/MuseScore/pull/3289
True, your PR is for master, but I believe it could quite easily also get cherry picked for 2.2 (except for one line)
In reply to True, your PR is for master,… by Jojo-Schmitz
I concur, but am still finding my way around. I am open to guidance.
Is there a header constant which tells me which version of MuseScore import it should be using? Should there be?
In Plugins you mean? If so, look at the one line of your PR I mentioned that should not make it back into 2.2.
Inside a plugin you can check the values of mscoreMajorVersion, mscoreMinorVersion and mscoreUpdateVersion
Could do that, certainly. I'm just a bit puzzled about how/when make contributions to 2.2, and how to flag it.
In the case of the PR at hand here nothing is needed, @lasconic is aware and would drop that line from a cherry-pick.
Fixed in branch master, commit 5ee17a8ae9
Fix #249631: Add SaveAs to PluginCreator
Also changed "New" to generate correct version of import MuseScore
Also added a "Save To:" message while saving.
Fixed in branch master, commit 21783cf84f
Merge pull request #3289 from rjmatthews62/fix_249631_clean
Fix #249631: Add SaveAs to PluginCreator
Fixed in branch 2.2, commit 6c03a794f4
Fix #249631: Add SaveAs to PluginCreator
Also changed "New" to generate correct version of import MuseScore
Also added a "Save To:" message while saving.
Automatically closed -- issue fixed for 2 weeks with no activity.