Some translated Tours strings show up as untranslated
Reported version
3.x-dev
Type
Wording/Translation
Frequency
Few
Severity
S3 - Major
Reproducibility
Always
Status
closed
Regression
No
Workaround
No
Project
Related to :
- #280538: Some Tours strings show up as untranslated
- #285019: Tours strings for French shows up untranslated
Tested with :
- OS: Windows 7 SP 1 (6.1), Arch.: x86_64, MuseScore version (64-bit): 3.1.0.5886, revision: dd5cfaf
Some examples:
- Welcome - Main menu
-
Welcome - Score view
-
Note input - Rnter note
-
Note input - Add accidental
And some others tours have to be checked.
Fix version
3.1.0
Comments
Not sure where the development builds get their translations from, @Anatoly-os?
In reply to Not sure where the… by Jojo-Schmitz
@Jo-Jo, yes sure, your PR has been merged in Master, could it be merged in 3.0.4 ? So we can verify in the release environment.
It should get merged to 3.0.5, due mid next week IIRC
In reply to @Jo-Jo, yes sure, your PR… by JLWaltener
Or more exactely in the next release...
Update :
- After the switching of ressource manager to Master 3.1.0, all new string has been pushed to Transifex.
- 8 Tours strings had to be retranslated - > Done for French.
- 47 total tours are translated.
- One still shows as untranslated = Welcome -> This is the score view.
OS: Windows 7 SP 1 (6.1), Arch.: x86_64, MuseScore version (64-bit): 3.1.0.6155, revision: 09ef1d4
OS: Windows 7 SP 1 (6.1), Arch.: x86_64, MuseScore version (64-bit): 3.1.0.6437, revision: 06f0ddd
OS: Windows 7 SP 1 (6.1), Arch.: x86_64, MuseScore version (64-bit): 3.1.0.6434, revision: 25c8a3e
The reason is because the file "tourxml.h" in "https://github.com/musescore/MuseScore/tree/master/share/tours" is outdated.
For example, in the Welcome Tour, the string "This is the score view, where you can view and edit your score.
Use your mouse wheel or touchpad to scroll (with "Shift" to scroll horizontally).
If you have multiple scores open, you can switch between them using tabs at the top of your score view." is different of those find in tourxml.h "This is the score view, where you can view and edit your score.\n Use your mouse wheel or touchpad to scroll (with Shift to scroll horizontally).\n"
You can see that the quotes around the word Shift does not exist.
As tourxml.h is outdated, the tours_*.ts are also outdated, and the source string in Transifex is also outdated.
The solution could be to regenerate tourxml.h and update .ts files and update Transifex.
Good point, thanks for that analysis!
And while at it the same method should be used to regenerate instrumentsxml.h
There's a python script doing this, I guess it should be possible to run that in the "MacOS_lupdate" job on Travis CI?
See https://github.com/musescore/MuseScore/pull/4917, which at least adds a readme about this
In reply to See https://github.com… by Jojo-Schmitz
Thanks for this readme, it precise the steps to update strings.
Automate the update in Travis would be an help to not forget a new or updated string.
As I can see, there is "script.sh" in "https://github.com/musescore/MuseScore/tree/master/build/travis/job_mac…"
Where the translation update is in lines :
Translation routines
update translation on transifex
./build/gen-qt-projectfile . > mscore.pro
lupdate mscore.pro
./build/gen-instruments-projectfile ./share/instruments > instruments.pro
lupdate instruments.pro
./build/gen-tours-projectfile ./share/tours > tours.pro
lupdate tours.pro
A call to the python files could be here.
In the mean time of this modification, could we have the tours strings updated before 3.1.0 release ?
One problem is https://github.com/musescore/MuseScore/pull/4516, which added a tour that isn't translatable/translated at all.
In 2b064401 I though to have done everything needed, apperently not so though, I seem to have missed a string or 3... downside of not having Python available to run thnat script.
See https://github.com/musescore/MuseScore/pull/4917, tourxml.h now updated too.
Still not automated though
In reply to Culprit seems to have been … by Jojo-Schmitz
Yes, I have seen that PR during the search of that bug, it's why integrate the python files in the script will avoid and automate that.
Updating 47 very long strings is really dificult, many things could be forgotten.
In reply to See https://github.com… by Jojo-Schmitz
Really nice :) You have installed Python on your Windows PC ! Chapeau bas.
And I think the automation will arrive not in hurry, we will have all translated for 3.1.0 release.
Really thanks a lot.
No, I tried and failed, but I got access to a Linux machine, transfered that tours directory there, ran the script and transfered tourxml.h back ;-)
Fixed in branch master, commit f4fce47fb8
_fix #285517: update tourxml.h and add a readme to the tours directory
to make clear which steps are needed to update their translations_
Fixed in branch master, commit a2a7cee9a8
_Merge pull request #4917 from Jojo-Schmitz/tours
fix #285517: update tourxml.h and add a readme to the tours directory_
Automatically closed -- issue fixed for 2 weeks with no activity.