Excerptdialog: New All creates two parts instead of one fbrauchle • May 9, 2016 - 18:47 Reported version 3.0 Type Functional Severity S2 - Critical Status closed Project MuseScore nightly 755bf05 Ubuntu 16.10 1. My first Score 2. Parts... -> 2x "New all" -> "Ok" 3. Parts... -> 2x "Delete" -> 1x "New all" -> "Ok" Result: There are two parts again. Reply Comments Jojo-Schmitz • May 9, 2016 - 19:20 Not here on Windows 7, I get a crash instead Strange stack trace: 1 Ms::deleteExcerpt(Ms::Excerpt *) 0x8b4781 2 msvcrt!free 0x75e898cd 3 ?? 0x3a0000 4 ZN15QListWidgetItemD2Ev 0x1f81afe 5 ?? 0x4 6 ?? 0x8f262c0 7 ?? 0x7a 8 ?? 0x1c 9 ?? 0x47dd01f3 10 ?? 0x8c00ffed 11 ?? 0x1 12 ?? 0x5 13 ?? 0x10 14 MgStyle::drawScrollBarSliderControl(QStyleOption const *, QPainter *, QWidget const *) const 0x6c0046 Console Output: First pass : delete unwanted parts Second pass : create new parts + Add part : "Piano" + Add part : "Piano" Fourth pass : Reordering parts Nb parts in score->excerpts().size() = 2 Nb parts in the parts dialog : excerptList->count() = 2 First pass : delete unwanted parts - Deleting parts : "Piano" - Deleting parts : "\u0000?\u0000\u0000" So it tries to delete a part with no Name? Reply fbrauchle • May 9, 2016 - 20:05 Okay this is interesting. Sounds if there is a pointer to a deleted reference, because I guess I adressed the old element again and it wasn't already erased on Ubuntu. I'll print my output later. Reply fbrauchle • May 10, 2016 - 07:02 Status (old) active ⇒ patch (code needs review) Reply Jojo-Schmitz • May 10, 2016 - 08:23 see https://github.com/musescore/MuseScore/pull/2592 Edit: I tested the patch on Windows, and it seems to fix the problem, no crash or other faults Reply Git Message • May 12, 2016 - 09:58 Status (old) patch (code needs review) ⇒ fixed Fixed in branch master, commit 05b69d8f59 fix #110376 fix #110371: Problems with New All and Delete in Excerptsdialog Reply Git Message • May 12, 2016 - 09:58 Fixed in branch master, commit 55d755e241 Merge pull request #2592 from Rockettwo/110376-excerptsdialog-allnew-delete fix #110376 fix #110371: Problems with New All and Delete in Excerptsdialog Reply System Message • May 26, 2016 - 10:00 Status (old) fixed ⇒ closed Automatically closed -- issue fixed for 2 weeks with no activity. Reply
Jojo-Schmitz • May 9, 2016 - 19:20 Not here on Windows 7, I get a crash instead Strange stack trace: 1 Ms::deleteExcerpt(Ms::Excerpt *) 0x8b4781 2 msvcrt!free 0x75e898cd 3 ?? 0x3a0000 4 ZN15QListWidgetItemD2Ev 0x1f81afe 5 ?? 0x4 6 ?? 0x8f262c0 7 ?? 0x7a 8 ?? 0x1c 9 ?? 0x47dd01f3 10 ?? 0x8c00ffed 11 ?? 0x1 12 ?? 0x5 13 ?? 0x10 14 MgStyle::drawScrollBarSliderControl(QStyleOption const *, QPainter *, QWidget const *) const 0x6c0046 Console Output: First pass : delete unwanted parts Second pass : create new parts + Add part : "Piano" + Add part : "Piano" Fourth pass : Reordering parts Nb parts in score->excerpts().size() = 2 Nb parts in the parts dialog : excerptList->count() = 2 First pass : delete unwanted parts - Deleting parts : "Piano" - Deleting parts : "\u0000?\u0000\u0000" So it tries to delete a part with no Name? Reply
fbrauchle • May 9, 2016 - 20:05 Okay this is interesting. Sounds if there is a pointer to a deleted reference, because I guess I adressed the old element again and it wasn't already erased on Ubuntu. I'll print my output later. Reply
Jojo-Schmitz • May 10, 2016 - 08:23 see https://github.com/musescore/MuseScore/pull/2592 Edit: I tested the patch on Windows, and it seems to fix the problem, no crash or other faults Reply
Git Message • May 12, 2016 - 09:58 Status (old) patch (code needs review) ⇒ fixed Fixed in branch master, commit 05b69d8f59 fix #110376 fix #110371: Problems with New All and Delete in Excerptsdialog Reply
Git Message • May 12, 2016 - 09:58 Fixed in branch master, commit 55d755e241 Merge pull request #2592 from Rockettwo/110376-excerptsdialog-allnew-delete fix #110376 fix #110371: Problems with New All and Delete in Excerptsdialog Reply
System Message • May 26, 2016 - 10:00 Status (old) fixed ⇒ closed Automatically closed -- issue fixed for 2 weeks with no activity. Reply
Comments
Not here on Windows 7, I get a crash instead
Strange stack trace:
1 Ms::deleteExcerpt(Ms::Excerpt *) 0x8b4781
2 msvcrt!free 0x75e898cd
3 ?? 0x3a0000
4 ZN15QListWidgetItemD2Ev 0x1f81afe
5 ?? 0x4
6 ?? 0x8f262c0
7 ?? 0x7a
8 ?? 0x1c
9 ?? 0x47dd01f3
10 ?? 0x8c00ffed
11 ?? 0x1
12 ?? 0x5
13 ?? 0x10
14 MgStyle::drawScrollBarSliderControl(QStyleOption const *, QPainter *, QWidget const *) const 0x6c0046
Console Output:
First pass : delete unwanted parts
Second pass : create new parts
+ Add part : "Piano"
+ Add part : "Piano"
Fourth pass : Reordering parts
Nb parts in score->excerpts().size() = 2
Nb parts in the parts dialog : excerptList->count() = 2
First pass : delete unwanted parts
- Deleting parts : "Piano"
- Deleting parts : "\u0000?\u0000\u0000"
So it tries to delete a part with no Name?
Okay this is interesting.
Sounds if there is a pointer to a deleted reference, because I guess I adressed the old element again and it wasn't already erased on Ubuntu.
I'll print my output later.
see https://github.com/musescore/MuseScore/pull/2592
Edit: I tested the patch on Windows, and it seems to fix the problem, no crash or other faults
Fixed in branch master, commit 05b69d8f59
fix #110376 fix #110371: Problems with New All and Delete in Excerptsdialog
Fixed in branch master, commit 55d755e241
Merge pull request #2592 from Rockettwo/110376-excerptsdialog-allnew-delete
fix #110376 fix #110371: Problems with New All and Delete in Excerptsdialog
Automatically closed -- issue fixed for 2 weeks with no activity.