[trunk] Shortcuts not read back from .ini file

• Jul 26, 2011 - 07:15
Type
Functional
Severity
S4 - Minor
Status
closed
Project

Setup: SVN rev. 4595; Qt Lib 4.7.3; Ubuntu 11.04

Description: if custom shortcuts are defined, they are saved into .ini file, but not read back.

Analysis: This happens because when shortcuts are read back (file preferences.cpp, function readShorcuts()), the global QMap shortcuts has not been initialized yet and the function reports a number of error messages like: MuseScore:readShortCuts: unknown tag <pitch-down-octave>.

In function main(), the function initShortcuts() should be called before preferences.read() is called (line 2144) and not much later (line 2255) as now.

The attached patch fixed this. As initShortcuts() was initially called earlier and has been moved later for some reason, it is wise to check the patch before applying it.

Thanks,

M.

Attachment Size
trunk_musescore_cpp_read_shortcuts.patch 633 bytes

Comments