[trunk] Page Settings dlg box: first page num and page height weird behaviour

• Feb 25, 2012 - 11:09
Type
Functional
Severity
S4 - Minor
Status
closed
Project
MuseScore

Context: trunk r. 5376

Steps:
1) Open the "Layout | Page Settings..." dlg box
2) type a number into the "First page no" edit box

Result: the typed number is automatically modified (usually to 1 unity greater); for instance, type "3": "4" is shown (and will be set into the score on leaving the dlg box).

Patch:

The attached patch changes the function PageSettings::pageOffsetChanged() (file mscore/pagesettings.cpp, line 465) from:
    preview->score()->setPageNumberOffset(val);
to:
    preview->score()->setPageNumberOffset(val-1);
as the internally stored value for the page number offset is <shown value> - 1.

(as I happened to notice, I have also commented out an unused QString var in line 162 of the same file...)

Thanks,

M.

Attachment Size
trunk-pagesettings_cpp-first_page_num.patch 632 bytes

Comments

• Mar 9, 2012 - 23:59

Context: rev. 5437.

In addition to the issue described above, the same dlg box has another strange behaviour:

Steps:

1) Open the "Layout | Page Settings..." dlg box
2) Change the Page Heihgt value

Result: Page Width and Page Height are exchanged; this triggers changes in Portrait/Ladscape and in margins.

Patch:

The attached patch, includes the fix above and also fixes this new point by swapping val and val2 in the statement:

f.setSize(QSizeF(val, val2));

of function void PageSettings::pageHeightChanged(double val), line 483. This was probably a copy-and-paste overlook...

Issues and patches have been cumulated as they refer to the same source file.

Thanks,

M.

Attachment Size
trunk-pagesettings_cpp.patch 948 bytes

Reply