Regression: unexpected display in "Preview" of Tab staff for instruments of less than 6 strings/lines

• Mar 27, 2017 - 08:32
Reported version
2.2
Type
Functional
Severity
S4 - Minor
Status
active
Project

GIT commit: ae09a44 / Windows7

1) Create a new score for Ukulele [Tablature], ie: Uke tab.mscz
2) Right-click -> Staff Properties -> Advanced Style Properties
3) Look at to the "Preview"

Expected result (as in the 2.0.3)
Preview0.jpg

Current result (unexpected extra basses on ledger lines)
Preview.jpg

- And same result for all instruments with 5 strings (eg banjo and others), with 3 strings (eg balalaïka and others), and so with 4 strings (ukulele, and others).
Works if the instruments have 6 strings/lines (but not if you decrease the number of lines for such or such purpose)

- This display is a consequence of the fix of this feature request: #174066: Why not add the lute functionality to 2.1 (especially bass courses)?


Comments

Title Unexpected display in "Preview" of Tab staff for instruments containing less of 6 strings/lines Regression: unexpected display in "Preview" of Tab staff for instruments of less of 6 strings/lines
Status (old) active needs info

FWIW, the original problem isn't exactly a bug, at least not in the normal sense. The preview is simply displaying a particular score - the one attached to this comment. As you can see if you load the score into MuseScore normally, the score calls for six strings. Previous versions of MuseScore had no concept of how to display this on a four-line staff, so I guess the low notes were simply chopped off. As far as I can tell, the current version is displaying it "properly" to the extent it makes sense to display a six-line score on a four-line staff - I gather this is exactly the point of the new lute functionality?

Perhaps we should have separate sample scores for four-line staves, or we need special code to simply ignore the notes on the lower strings unless we are deliberately using the new lute bass feature.

But if you are seeing a problem on regular scores - scores that are actually created for the correct number of strings - then that seems different. But I don't see any problem loading your score. Are there steps I need to follow to reproduce the problem?

Attachment Size
tab_sample.mscz 8.19 KB
Status (old) needs info active

1) Create a score for balalaïka -> Change staff type: Tab. balalaïka (so, default 3 lines/strings)
2) Staff properties -> Advanced Style Properties
3) The "Preview" displays unexpected extra notes under the three default lines.
File : Balal.mscz

Title Regression: unexpected display in "Preview" of Tab staff for instruments of less of 6 strings/lines Regression: unexpected display in "Preview" of Tab staff for instruments of less than 6 strings/lines
Status (old) active needs info

Just to throw gasoline on the fire. What about 3 5, 7 and more stringed instruments? I realize 7 and more will display correctly with empty strings, so they don't really matter. What hasn't been mentioned since the first post is that the 4 line displayed correctly in 2.0.3.

Status (old) needs info active

"What about 3 5, 7 and more stringed instruments?"
First, please, the Issue Tracker is not a forum. I reply though because:
As said in the title, the problem concerns the Preview for instruments (in Advanced Style Properties) of 3 strings (eg balalaïka), 4 strings (eg ukulele), 5 strings (eg banjo)
For other instruments, 7 and more strings, see eg: https://musescore.org/fr/node/179226

This is the place to discuss issues to consider for fixing bugs such as this. You and I were previously typing at the same time. Marc was only talking about 4 string instruments and I didn't want the fix to only fix one special case, which is what would happen if a 4 string staff were used for 4 string tablatures.

Maybe I didn't explain clearly enough?

What I am saying is, I don't think what you are seeing in the preview is a bug at all. I think it is *correctly* displaying the music in the score it is uses for the preview (the score I attached to my comment). That score contains music for six strings, but it is being displayed on a four stringed staff. As far as I can tell, the use of notes below the staff is the *correct* way to display that according to the new lute bass note feature. Which is to say, for the first time, MuseScore is actually displaying that score correctly, rather than leaving out the bass notes as it used to do. Or are you saying that it is *not* the correct way to use this lute feature? Could be, I don't totally understand it myself. But from the screenshots and discussion in https://musescore.org/en/node/67261, it doesn't seem obviously wrong to me.

We could certainly consider using a different sample score to display in the preview - one that only uses three strings, say, or maybe different sample scores for different instruments - to avoid confusion since probably most ukulele players don't care about the new lute bass note feature and don't need to see it demonstrated. But as far as I can tell, the score that is being displayed is being displayed correctly. Or, if it isn't, then presumably the same issue would show up in actual use, not just the demonstration score. And it would make sense to file the issue that way.

What I was asking for information about is the apparently separate issue discussed in comment #1, where I thought it was being claimed there was an actual problem with how MuseScore renders an actual score, not just a question about what features are appropriate to demonstrate in the preview window. I am not able to reproduce any problem with that score. So that is what I am asking for steps to reproduce.

So bottom line: as far as I can tell, the preview window is correctly demonstrating the new lute features, and hence this is not a bug, except to the extent that maybe we don't really need to be demonstrating those features here.

"What I was asking for information about is the apparently separate issue discussed in comment #1."
Who spoke of an "apparently" separate issue? Not me. Otherwise, I will have opened a new thread. In comment # 1, I do not know how to be clearer, I show a picture showing an extract of the Preview of this score (again in Advanced style Properties) not the score itself in usual use.

"to avoid confusion since probably most ukulele players don't care about the new lute bass note feature and don't need to see it demonstrated."
That'is, and that's all, not more not less.

Sorry, my misunderstanding of your comment in #1. I think the classification as "major" misled me into thinking there was an actual problem with a score. As it is, if it is just a matter that the demonstration score used for the preview shows off some features that might kot actually be used, that seems much less serious.