Regression: Save Online shows 'upload audio' when updating score, regardless of default synthesitzer settings
Make sure synthesizer settings are at default (e.g. use -F)
Create new score
Save online (For master the -e flag is needed to be able to save online)
Save online again
expected result: the add autio part of the dialog is not visible
actual result: the add autio part of the dialog is visible
Windows 7 and 10, all builds of master and 2.1 since that feature got implemented (8783e76 for 2.1, (63cbfeb for master), up to at least 22033c8 (2.1) and f264716 (master)
Comments
The decision whether to show that part of the dialog or not is made at mscore/uploadscoredialog.cpp, line 211 or rather libmscore/synthesizerstate.cpp, lines 79-89
But this code is executed only the 1st time, not when updating the score!
See https://github.com/musescore/MuseScore/pull/3137
But this code is executed only the 1st time, not when updating the score!
Yes, so why the add audio part of the dialog would be visible !? It's the only place where setVisible is called. I still can't reproduce... that's crazy.
That is the problem, it needs to be set at 2 places, check my PR
Fixed in branch master, commit 0cf60e7d5d
fix #187386: Save Online shows 'upload audio' when updating score, regardless of default synthesitzer settings
Fixed in branch master, commit f6eef924ce
Merge pull request #3137 from Jojo-Schmitz/uploadscore
fix #187386: Save Online shows 'upload audio' when updating score, regardless of default synthesitzer settings
Fixed in branch 2.1, commit 9f69f777bc
fix #187386: Save Online shows 'upload audio' when updating score, regardless of default synthesitzer settings
Automatically closed -- issue fixed for 2 weeks with no activity.