Languages

lupdate problems

• Aug 11, 2017 - 08:48

Reported version

3.0

Type

Functional

Severity

S4 - Minor

Status

closed

Project

When running 'make lupdate', besides taking ages on Windows, the following errors/warnings get printed:

.../MuseScore/libmscore/durationtype.cpp:787: Qualifying with unknown namespace/class ::TDuration
.../MuseScore/libmscore/mscore.cpp:467: Class 'Ms::MScore' lacks Q_OBJECT macro
.../MuseScore/mscore/editdrumset.cpp:95: Class 'Ms' lacks Q_OBJECT macro
.../MuseScore/mscore/inspector/inspectorTextLine.cpp:27: Cannot invoke tr() like this
.../MuseScore/mscore/inspector/inspectorTextLine.cpp:27: Class 'Ms' lacks Q_OBJECT macro
.../MuseScore/mscore/inspector/inspectorTextLine.cpp:28: Cannot invoke tr() like this
.../MuseScore/mscore/inspector/inspectorTextLine.cpp:29: Cannot invoke tr() like this
.../MuseScore/mscore/inspector/inspectorTextLine.cpp:39: Cannot invoke tr() like this
.../MuseScore/mscore/inspector/inspectorTextLine.cpp:40: Cannot invoke tr() like this
.../MuseScore/mscore/inspector/inspectorTextLine.cpp:41: Cannot invoke tr() like this
.../MuseScore/mscore/inspector/inspectorTextLine.cpp:42: Cannot invoke tr() like this

Any idea anyone why that is and how to fix it?

Reply

Comments

• Aug 11, 2017 - 10:25

Hmm, I may have found it out myself: adding a QObject:: in front of the tr(...)seems to fix these, all, but the first

• Aug 11, 2017 - 10:52

Status (old)	active	⇒	patch (code needs review)
Status	active	⇒

See https://github.com/musescore/MuseScore/pull/3273

• Aug 14, 2017 - 11:14

Status (old)	patch (code needs review)	⇒	fixed
Status		⇒	fixed

Fixed in branch master, commit 264b0386d4

Fix #243656: Warnings/Errors from lupdate

All but one...

• Aug 14, 2017 - 11:14

Fixed in branch master, commit 09eb2a0f85

Merge pull request #3273 from Jojo-Schmitz/lupdate

Fix #243656: Warnings/Errors from lupdate

• Aug 28, 2017 - 12:00

Status (old)	fixed	⇒	closed
Status	fixed	⇒	closed

Automatically closed -- issue fixed for 2 weeks with no activity.