Ties broken when changing pitches in repitch mode
Windows 7, GIT commit: ea1e881
1) create new score
2) enter a half note C tied to an eighth note
3) switch to repitch mode
4) move cursor if necessary back to the half note
5) press D
Expected result: the half note & eighth both become D
Actual result: the half note become D but the eighth remains C, thus breaking the tie
If the whole point of repitch mode is to allow you to just key in new pitches over an existing melody while the original rhythms are preserved, then ties should not prevent this from working
Comments
Investigation this led me to discover #26516: Crash on use of repitch mode. Seeing if I can fix both...
I have a fix:
https://github.com/musescore/MuseScore/pull/992
I am not sure the way I am updating the tied notes is correct/optimum. I simply copy the pitch, tpc, tpc1, and tpc2 from the new note.
Updated PR to use undoChangePitch, which seems the right way to do it - and it works with linked staves/parts.
Ties need to be handled separately for MIDI input because that's currently handled elsewhere - in Score::addPitch(). Although that function needs a bit of work for #25600: Notes entered with wrong enharmonic spelling from MIDI input or "R" command in note input. It's possible the repitch functionality could be farmed off to Score::repitchNote() and thus take advantage of the tie-handling I just added.
I updated my PR to perform tie-handling for MIDI input as well; I just copied (and adapted) the code from repitchNote() to addPitch().
Fixed in 2b803a7cf8
Automatically closed -- issue fixed for 2 weeks with no activity.