Text is not the same in "create mmRest" mode an "normal" mode
Hello,
Text is not the same in "create mmRest" mode an "normal" mode
1 - Create 10 empty measure
2 - Add text to one measure in the middle
3 - Switch to "mmRest" mode "M"
4 - Modify text
5 - Switch between "mmRest" mode and "normal" mode, the text is not the same
if you remove the text in the "mmRest" mode, the initial text appear.
Robert
Comments
Confirmed - but also, I had no idea there was a shortcut for "mmrest mode"!
The problem is probably that we clone the element from the first measure to the mmRest and it's not a good approach.
https://github.com/musescore/MuseScore/blob/8e696d1dd8ba08e77938342f7c2…
Yes you can clone it, but you have to keep a reference to the original cloned text to have feedback on initial text.
I take a look Yesterday to mmRest code.
I try to understand on how it work and i think part of the the First Measure and Last Measure was cloned in one mmRest attached to first measure. this mmRest is include in the chained list of measures.
For now mmRest is not saved and all manual adjust was lost.
I see some options for the future
1)This mmRest is cloned and it's an independant measure. We can preserve this mode assuming that text in text element is also independant. In this case, we need to save this mmRest with the rest of score. you can do all manual adjust you want independant of the initial measure.
2)This mmRest is cloned and it's partially an independant measure. We can preserve this mode but forcing text to be same as original text (Some modification are done and work partially). In this case you can't make manual adjust to the text of mmRest but for all the mmRest you can. In this case, we need to save this mmRest with the rest of score.
3)This mmRest is cloned but create each time from scracth and none adjust can be make. You don't need to save it with rest of file.
Actually is a mix with 1,2,3 with no save.
What do you think about that? and do you have anothers ideas?
Robert
This should be fixed now. Tested with 7616e3be6b
Hello,
Yes it's work, but the position was not saved for the two state. Save only the last position view: mmRestmode or not.
I think the two rest must be saved, the first Measure and the attached mmRest.
Robert
Please give exact steps to reproduce. The bug report was about text being different and this is fixed. Regarding the position, the position of the text when mmRest is on and off is different and that's normal since the layout is different as well. Both position are saved and persist between save and open. For me this bug is fixed, and there is no problem with position, do you see something different?
When i say saved. It's in file.
In short way, only one state position was saved in file. I put a better description tonight.
The text is saved twice now. See https://github.com/musescore/MuseScore/commit/82c8dc5b7212347fbf1c594ce…
I put this on fixed, reopen if necessary.
Seem to work, thank's
Automatically closed -- issue fixed for 2 weeks with no activity.