Chord height wrong in imported 1.3 scores with default text style

• Feb 16, 2014 - 13:48
Type
Functional
Severity
S4 - Minor
Status
closed
Project
MuseScore

Visual layout should be preserved as much as possible in v2.0 when opening v1.3 files.

This would appear not to be the case, however.

Here is a case in point.
Score created in v1.3, using the chord name definition file "cchords_muse_it.xml" (which came with the installation).
No other visual parameters are changed.

When opened with the nightly build (MuseScoreNightly-2014-02-11-1208-831686d.7z), the chord names are no longer in the French/Italian style and the chords are sitting on the top line of the stave.

In addition, the rendering of the score is of a poorer quality as that of v1.3.

Attached to this issue are the following files

  • v1-3-rendering.png
    Screen capture of the file as rendered upon opening by v1.3
  • nightly-build-rendering.png
    Screen capture of the file as rendered upon opening by the nighly build
  • 414 - Grandes_et_merveilleuses.mscz
    v1.3 score file used for comparison
  • cchords_muse_it.xml
    Chord name style file

Are there any other files needed to support this issue ?

Comments

• Feb 16, 2014 - 16:13
Title Problems with layout compatbility ⇒ Chord height wrong in imported 1.3 scores with default text style

Did you copy your cchords_muse_it.xml file from the 1.3 installation to the 2.0? The path to a custom chord description file is *not* hardcoded in your score; it has to be found in the default installation folder. When I copy your XML file to the 2.0 installation, I get the Italian chord symbols. Nothing we can do about the fact that existing files don't have full path info, and in general, hardcoding paths is bad for portability, so that much is pretty much just the way it is - if you use custom chord description files, it's up to you to manage them. 2.0 improves portability going forward by saving the contents of custom chord description files in your scores, so your scores load correctly even if the XML file can't be found.

However, the chord heights are still wrong. This seems to happen only for scores that used the default chord height in 1.3 - scores that customize chord height in the text style work correctly.

I've changed the title to be more specific about the nature of the problem, and I should have a fix shortly.

Reply

• Feb 16, 2014 - 16:23

Thanks Marc.
I confirm that it is necessary to copy any non-default styles from v1.3 to v2.0, even if they came as standard with v1.3.
Once done, the chord names styles are correctly applied.
Leaves the issue that we both identified - that of chord distances.

Reply

• Feb 16, 2014 - 18:33
Status (old) active ⇒ patch (ready to commit)

Not sure what you mean about "even if they came as standard with 1.3". That shouldn't be true. The same styles shipped as standard with 1.3 are also shipped as standard with 2.0, so you should be free to switch between any of the standard chord description files without taking special steps. Only if you added your own custom files that were *not* shipped with 1.3 do you need to copy them into your 2.0 distribution folder just as you did for 1.3.

To be clear, cchords_muse_it.xml was *not* shipped with 1.3, unless maybe it was included as part of some special Italy-and-France-only distribution or something, which I rather doubt. But in that case, it should be included in a similar distribution for 2.0 when the time comes.

Anyhow, I have submitted a PR to fix the chord height issue:

https://github.com/musescore/MuseScore/pull/703

Travis builds seem broken right now, and I'll probably need to update a test, but the code works.

Reply