Copyright info from score not propagated to parts

• Apr 6, 2014 - 04:42
Type
Functional
Severity
S4 - Minor
Status
closed
Project
MuseScore

Windows 7, GIT commit: 1132f3d

1) create score, fill in copyright text
2) file/ parts
3) new all, OK
4) view a part

Result: no copyright info displays (go to file / info if you wouldn't normally see copyright info due to header settings anyhow)

Comments

• Apr 6, 2014 - 07:13

Now that's weird. I just generated parts again and this time I got the copyright. In fact, when I go to File / Info in a part now, I get a mostly empty dialog that doesn't even *let* me add copyright message. Before, I got an almost full dialog with everything but composer, and copying the score copyright into here was how I worked around the problem. Hmm.

Anyone else care to try to reproduce?

EDIT: OK, maybe there copyright info is there at first, then it disappears after save/reload?

Reply

• Apr 8, 2014 - 19:22

I've just reproduced this bug in revision 7a46181.

As you said, the copyright disappears after loading a score.

Steps to reproduce:

1) create score, fill in copyright text
2) file/ parts
3) new all, OK
4) save score
5) load score
6) view a part

result - No copyright text in the parts.

At first sight this looks like the copyright text in the parts is not saved.

Reply

• Apr 9, 2014 - 22:56

The bug is caused by not copying the parent scores metaTags when creating a new Part.

When the score was then saved, the resulting xml didn't have the copyright meta tag in the children scores.

Upon loading, the default values where added to metaTags, which resulted in the copyright field being blank.

My concern is this function:
{syntaxhighlighter brush:cpp;first-line:1933;}
Q_INVOKABLE QString Score::metaTag(const QString& s) const
{
if (_metaTags.contains(s))
return _metaTags.value(s);
return rootScore()->_metaTags.value(s);
}
{/syntaxhighlighter}

Which masked the problem by showing the rootScores copyright, since upon creating the Part, the _metaTags was empty.

Or should the parts never have the _metaTags, so they will take it from the parent? Can the copyright tag be different in a children score?

Reply