this issue applies to master only, and the proposed fix does need a review, as prior to it the 2nd condition got ignored, it previously was the only condition, so the added one (which does different things than the 2nd) might have been a mistake, but now they are integrated.
Comments
Good catch, mscore/scoreview.cpp, line 1740 and mscore/scoreview.cpp, line 1811 are indeed duplicates.
And dealt with already in https://github.com/musescore/MuseScore/pull/3302
See also https://musescore.org/en/node/255156
Strange - probably I was not on head version. Found with cppcheck - more tools are better :-)
No, the bug is still in, but a PR to get it fixed is pending, so work in progress
See also https://github.com/musescore/MuseScore/pull/3313
this issue applies to master only, and the proposed fix does need a review, as prior to it the 2nd condition got ignored, it previously was the only condition, so the added one (which does different things than the 2nd) might have been a mistake, but now they are integrated.
Fixed in branch master, commit d9544a7498
Fix #258131: duplicate condition in mscore/scoreview.cpp
see also https://musescore.org/en/node/255156 and PR #3302
Automatically closed -- issue fixed for 2 weeks with no activity.