twin include mscore/scoretab.cpp lines 25 and 26 maddin200 • Oct 12, 2017 - 18:59 Reported version 2.1 Type Functional Severity 3 Status closed Project MuseScore Tags easy /mscore/scoretab.cpp) (line 26): include twice (scoreview.h) Reply Comments Jojo-Schmitz • Oct 12, 2017 - 19:04 Title twin include ⇒ twin include mscore/scoretab.cpp lines 25 and 26 Severity ⇒ mscore/scoretab.cpp, line 25 and mscore/scoretab.cpp, line 26 are indeed duplicates. Reply Jojo-Schmitz • Oct 13, 2017 - 14:30 Severity ⇒ Status (old) active ⇒ patch (code needs review) Status active ⇒ Tags View Changes See https://github.com/musescore/MuseScore/pull/3313 Reply Jojo-Schmitz • Oct 14, 2017 - 09:59 Severity ⇒ Status (old) patch (code needs review) ⇒ patch (ready to commit) Status ⇒ PR created Reported version 3.0 ⇒ 2.1 Issue and fix apply to master and 2.x Reply Git Message • Nov 16, 2017 - 16:37 Severity ⇒ Status (old) patch (ready to commit) ⇒ fixed Status PR created ⇒ fixed Fixed in branch master, commit 0e6b9d9fdf Fix #258146: duplicate header file in mscore/scoretab.cpp Reply Jojo-Schmitz • Nov 16, 2017 - 21:59 Severity ⇒ Status (old) fixed ⇒ active Status fixed ⇒ active Could go to 2.2 too Reply Jojo-Schmitz • Nov 16, 2017 - 22:18 Severity ⇒ Status (old) active ⇒ fixed Status active ⇒ fixed Ah, I see it is in 25f03fe Reply System Message • Dec 1, 2017 - 09:00 Severity ⇒ Status (old) fixed ⇒ closed Status fixed ⇒ closed Automatically closed -- issue fixed for 2 weeks with no activity. Reply
Jojo-Schmitz • Oct 12, 2017 - 19:04 Title twin include ⇒ twin include mscore/scoretab.cpp lines 25 and 26 Severity ⇒ mscore/scoretab.cpp, line 25 and mscore/scoretab.cpp, line 26 are indeed duplicates. Reply
Jojo-Schmitz • Oct 13, 2017 - 14:30 Severity ⇒ Status (old) active ⇒ patch (code needs review) Status active ⇒ Tags View Changes See https://github.com/musescore/MuseScore/pull/3313 Reply
Jojo-Schmitz • Oct 14, 2017 - 09:59 Severity ⇒ Status (old) patch (code needs review) ⇒ patch (ready to commit) Status ⇒ PR created Reported version 3.0 ⇒ 2.1 Issue and fix apply to master and 2.x Reply
Git Message • Nov 16, 2017 - 16:37 Severity ⇒ Status (old) patch (ready to commit) ⇒ fixed Status PR created ⇒ fixed Fixed in branch master, commit 0e6b9d9fdf Fix #258146: duplicate header file in mscore/scoretab.cpp Reply
Jojo-Schmitz • Nov 16, 2017 - 21:59 Severity ⇒ Status (old) fixed ⇒ active Status fixed ⇒ active Could go to 2.2 too Reply
Jojo-Schmitz • Nov 16, 2017 - 22:18 Severity ⇒ Status (old) active ⇒ fixed Status active ⇒ fixed Ah, I see it is in 25f03fe Reply
System Message • Dec 1, 2017 - 09:00 Severity ⇒ Status (old) fixed ⇒ closed Status fixed ⇒ closed Automatically closed -- issue fixed for 2 weeks with no activity. Reply
Comments
mscore/scoretab.cpp, line 25 and mscore/scoretab.cpp, line 26 are indeed duplicates.
See https://github.com/musescore/MuseScore/pull/3313
Issue and fix apply to master and 2.x
Fixed in branch master, commit 0e6b9d9fdf
Fix #258146: duplicate header file in mscore/scoretab.cpp
Could go to 2.2 too
Ah, I see it is in 25f03fe
Automatically closed -- issue fixed for 2 weeks with no activity.