2 twin includes in libmscore/cmd.cpp maddin200 • Oct 13, 2017 - 09:22 Reported version 2.1 Type Functional Severity 3 Status closed Project MuseScore Tags easy (libmscore/cmd.cpp) (line 65) (clef.h) (line 60): (sig.h) Reply Comments Jojo-Schmitz • Oct 13, 2017 - 14:08 Title twin includes ⇒ 2 twin includes in libmscore/cmd.cpp Severity ⇒ Tags View Changes I don't see this, clef.h and sig.h are only y included once Reply Jojo-Schmitz • Oct 13, 2017 - 14:11 Severity ⇒ Status (old) active ⇒ needs info Status active ⇒ needs info Reply Jojo-Schmitz • Oct 13, 2017 - 14:13 Severity ⇒ Status (old) needs info ⇒ active Status needs info ⇒ active Hmm, ok, cleaned my glasses and now see clef.h in line 24 and 65 and sig.h in line 32 and 60 Reply maddin200 • Oct 13, 2017 - 14:19 Severity ⇒ a little bit unfair - I used an internal tool Reply Jojo-Schmitz • Oct 13, 2017 - 14:29 Severity ⇒ Status (old) active ⇒ patch (code needs review) Status active ⇒ That's fine, keep it coming. See https://github.com/musescore/MuseScore/pull/3313 Reply Jojo-Schmitz • Oct 14, 2017 - 09:58 Severity ⇒ Status (old) patch (code needs review) ⇒ patch (ready to commit) Status ⇒ PR created Reported version 3.0 ⇒ 2.1 Issue and fix apply to master and 2.x Reply Git Message • Nov 16, 2017 - 16:37 Severity ⇒ Status (old) patch (ready to commit) ⇒ fixed Status PR created ⇒ fixed Fixed in branch master, commit 99d147afe1 Fix #258301: 2 duplicate header files in libmscore/cmd.cpp Reply Jojo-Schmitz • Nov 16, 2017 - 21:58 Severity ⇒ Status (old) fixed ⇒ active Status fixed ⇒ active Could go to 2.2 too Reply Jojo-Schmitz • Nov 16, 2017 - 22:19 Severity ⇒ Status (old) active ⇒ fixed Status active ⇒ fixed Ah, I see it is in 25f03fe Reply System Message • Dec 1, 2017 - 09:00 Severity ⇒ Status (old) fixed ⇒ closed Status fixed ⇒ closed Automatically closed -- issue fixed for 2 weeks with no activity. Reply
Jojo-Schmitz • Oct 13, 2017 - 14:08 Title twin includes ⇒ 2 twin includes in libmscore/cmd.cpp Severity ⇒ Tags View Changes I don't see this, clef.h and sig.h are only y included once Reply
Jojo-Schmitz • Oct 13, 2017 - 14:11 Severity ⇒ Status (old) active ⇒ needs info Status active ⇒ needs info Reply
Jojo-Schmitz • Oct 13, 2017 - 14:13 Severity ⇒ Status (old) needs info ⇒ active Status needs info ⇒ active Hmm, ok, cleaned my glasses and now see clef.h in line 24 and 65 and sig.h in line 32 and 60 Reply
Jojo-Schmitz • Oct 13, 2017 - 14:29 Severity ⇒ Status (old) active ⇒ patch (code needs review) Status active ⇒ That's fine, keep it coming. See https://github.com/musescore/MuseScore/pull/3313 Reply
Jojo-Schmitz • Oct 14, 2017 - 09:58 Severity ⇒ Status (old) patch (code needs review) ⇒ patch (ready to commit) Status ⇒ PR created Reported version 3.0 ⇒ 2.1 Issue and fix apply to master and 2.x Reply
Git Message • Nov 16, 2017 - 16:37 Severity ⇒ Status (old) patch (ready to commit) ⇒ fixed Status PR created ⇒ fixed Fixed in branch master, commit 99d147afe1 Fix #258301: 2 duplicate header files in libmscore/cmd.cpp Reply
Jojo-Schmitz • Nov 16, 2017 - 21:58 Severity ⇒ Status (old) fixed ⇒ active Status fixed ⇒ active Could go to 2.2 too Reply
Jojo-Schmitz • Nov 16, 2017 - 22:19 Severity ⇒ Status (old) active ⇒ fixed Status active ⇒ fixed Ah, I see it is in 25f03fe Reply
System Message • Dec 1, 2017 - 09:00 Severity ⇒ Status (old) fixed ⇒ closed Status fixed ⇒ closed Automatically closed -- issue fixed for 2 weeks with no activity. Reply
Comments
I don't see this, clef.h and sig.h are only y included once
Hmm, ok, cleaned my glasses and now see clef.h in line 24 and 65 and sig.h in line 32 and 60
a little bit unfair - I used an internal tool
That's fine, keep it coming.
See https://github.com/musescore/MuseScore/pull/3313
Issue and fix apply to master and 2.x
Fixed in branch master, commit 99d147afe1
Fix #258301: 2 duplicate header files in libmscore/cmd.cpp
Could go to 2.2 too
Ah, I see it is in 25f03fe
Automatically closed -- issue fixed for 2 weeks with no activity.