crash when opening styles dialog

• Oct 18, 2018 - 20:43
Reported version
3.0
Type
Functional
Severity
S2 - Critical
Status
closed
Project
MuseScore

As soon as I try to open the styles dialog it crashes/exits with:

no widget for QPointF <QWidget><pedalPosAbove>
no widget for QPointF <QWidget><pedalPosBelow>
no widget for QPointF <QWidget><vibratoPosAbove>
no widget for QPointF <QWidget><vibratoPosBelow>
no widget for QPointF <QWidget><tempoPosAbove>
no widget for QPointF <QWidget><tempoPosBelow>
no widget for QPointF <QWidget><rehearsalMarkPosAbove>
no widget for QPointF <QWidget><rehearsalMarkPosBelow>
no widget for QPointF <QWidget><textLinePosAbove>
no widget for QPointF <QWidget><textLinePosBelow>
no widget for QPointF <QWidget><fermataPosAbove>
no widget for QPointF <QWidget><fermataPosBelow>
no widget for QPointF <QWidget><staffTextPosAbove>
no widget for QPointF <QWidget><staffTextPosBelow>
unhandled gui widget type QWidget valueType pedalPosAbove
 
...\MuseScore\msvc.build_x64\mscore\..\..\msvc.install_x64\bin\MuseScore.exe (Prozess "6664") wurde mit Code "1073741845" beendet.

5138c8f, self built with MSVC. Got to be a very recent change, probably 5138c8f itself or d77183b

Comments

• Oct 21, 2018 - 10:16

This is an assertion failure in mscore/editstype.cpp. line 587

The widgets (QDoubleSpinBox) for "Position above" and "Position below" have been removed for Pedal, Vibrato, Fermatas, Text line, Staff text, Tempo text, and Rehearsal marks in d77183b from editstyle.ui but not from the styleWidgets array in editstyle.cpp and this is now causing this crash.

Reply

• Oct 21, 2018 - 11:56

Actually that QDoubleSpinBox had been replaced with an Ms::OffsetSelect, but to the above mentioned elements without the corresponding code change?

Reply

• Oct 21, 2018 - 12:47

Ah, now I got it, the real problem was that in in d77183b the widgets for "Position above" and "Position below" had been forgotten to get changed from QWidget to Ms::OffsetSelect in editstyle.ui for Pedal, Vibrato, Fermatas, Text line, Staff text, Tempo text, and Rehearsal marks.

PR updated and now should be the real fix

Reply

• Oct 21, 2018 - 16:25
Status (old) patch (code needs review) ⇒ fixed
Status ⇒ fixed

Fixed in branch master, commit 267ce91d12

fix #277274: crash when opening styles dialog

The widgets for "Position above" and "Position below" in `editstyle.ui`
had been forgotten to get changed in d77183b from `QWidget` to
`Ms::OffsetSelect` for Pedal, Vibrato, Fermatas, Text line, Staff text,
Tempo text, and Rehearsal marks.

Reply