Error message when no note selected untranslatable
Reported version
3.0
Type
Wording/Translation
Frequency
Few
Severity
S3 - Major
Reproducibility
Always
Status
closed
Regression
Yes
Workaround
No
Project
In any score, when no note are selected, trying to add a Figured bass open an error message.
This error message is untraslatable in Release 3.0.5 nor Dev build 3.1.0
this message box was translatable in Release 2.3.2
Fix version
3.3.0
Comments
The string is marked as being translatable, in libmscore/mscore.cpp, line138
And if this string doesn't show translated, quite a few more should have the same issue?
It doesn't show on Transifex, so indeed there is a problem, but not just for this string, all these error message sgtrtings are affected
see https://github.com/musescore/MuseScore/pull/4854
In reply to see https://github.com… by Jojo-Schmitz
Nice ! A fat finger dicovered one reveals 19 others...
Thanks joJo
Fixed in branch master, commit 6817a34032
_fix #286666: some error messages are not translated
seems
lupdate
is too dumb for such preprocessor trickery_Fixed in branch master, commit cfeaa32803
_Merge pull request #4854 from Jojo-Schmitz/translate-error-messages
fix #286666: some error messages are not translated_
Strings still don't show translated (in a development build, with updated translations and those string being translated on Transifex, at least into French and German) and the dialog does look different than in 2.x. Not sure the latter is a problem, but it might be the cause for the former?
Same happens when nothing is selected and you press X (well, slightly different error message: "No note or slur selected: Please select a note or slur and retry")
Found the culprit, mscore/musescore.cpp, line 1932
That
msg->showMessage(tr(MScore::errorMessage()), MScore::errorGroup());
needs to be
msg->showMessage(qApp->translate("error", MScore::errorMessage()), MScore::errorGroup());
instead
See https://github.com/musescore/MuseScore/pull/5212
In reply to See https://github.com… by Jojo-Schmitz
Tested with build OS: Windows 7 SP 1 (6.1), Arch.: x86_64, MuseScore version (64-bit): 3.2.0.7642, revision: 0f9da98
Thanks @Jojo-Schmitz
Fixed in branch master, commit 855956e508
_Fix #286666: Error message when no note selected untranslatable + collect_artifacts
Also translate the string for the "Unknown error" case_
Fixed in branch master, commit 742e066410
_Merge pull request #5212 from Jojo-Schmitz/error-translate
Fix #286666: Error messages show untranslated (like X when note note is selected)_
Automatically closed -- issue fixed for 2 weeks with no activity.