AlsaMidiDriver::putEvent control flow WTF

• Jul 3, 2019 - 04:03
Reported version
3.0
Priority
P3 - Low
Type
Functional
Frequency
Once
Severity
S4 - Minor
Reproducibility
Always
Status
active
Regression
No
Workaround
No
Project
MuseScore

I’d greatly appreciate if the one who wrote AlsaMidiDriver::putEvent had a look at it again. If error == -12 we already return true early (about halfway in the function), so the do { … } while (error == -12) loop CANNOT repeat.

What was really meant here? Simply removing the loop would fix the issue, but is that the correct fix?

Comments