AlsaMidiDriver::putEvent control flow WTF
Reported version
3.0
Priority
P3 - Low
Type
Functional
Frequency
Once
Severity
S4 - Minor
Reproducibility
Always
Status
active
Regression
No
Workaround
No
Project
I’d greatly appreciate if the one who wrote AlsaMidiDriver::putEvent had a look at it again. If error == -12 we already return true early (about halfway in the function), so the do { … } while (error == -12) loop CANNOT repeat.
What was really meant here? Simply removing the loop would fix the issue, but is that the correct fix?
Comments
Has been like this since initial commit (May 2012) and is still present in master.
Maybe looking in the old repository could help?
https://github.com/musescore/musescore-old/commit/803c4accd55212dbc8e80…
(I don't know what does it mean, I have just found the commit...)
In reply to Maybe looking in the old… by dmitrio95
Mh, still Werner… so someone tell him to please have a look at it ;)